Skip to content

Fix dataclass with default failing when validate_defaults=True#771

Merged
mauvilsa merged 1 commit into
mainfrom
issue-237-dataclass-default
Sep 10, 2025
Merged

Fix dataclass with default failing when validate_defaults=True#771
mauvilsa merged 1 commit into
mainfrom
issue-237-dataclass-default

Conversation

@mauvilsa

Copy link
Copy Markdown
Owner

What does this PR do?

Fixes #237 (comment)

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Sep 10, 2025
@codecov

codecov Bot commented Sep 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c2c7aa4) to head (c447e3d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #771   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6973      6976    +3     
=========================================
+ Hits          6973      6976    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

Copy link
Copy Markdown

@mauvilsa
mauvilsa merged commit df20921 into main Sep 10, 2025
31 checks passed
@mauvilsa
mauvilsa deleted the issue-237-dataclass-default branch September 10, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path_fr does not use the default value during validation

1 participant