Skip to content

Fix failure when parsing deeply nested dataclass with a union parent#839

Merged
mauvilsa merged 1 commit into
mainfrom
issue-838-nested-arg-dataclass
Feb 2, 2026
Merged

Fix failure when parsing deeply nested dataclass with a union parent#839
mauvilsa merged 1 commit into
mainfrom
issue-838-nested-arg-dataclass

Conversation

@mauvilsa

@mauvilsa mauvilsa commented Feb 2, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Fixes #838

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Feb 2, 2026
@codecov

codecov Bot commented Feb 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a2c72c1) to head (6dee3be).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #839   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         7273      7275    +2     
=========================================
+ Hits          7273      7275    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Feb 2, 2026

Copy link
Copy Markdown

@mauvilsa
mauvilsa merged commit 18c7645 into main Feb 2, 2026
31 checks passed
@mauvilsa
mauvilsa deleted the issue-838-nested-arg-dataclass branch February 2, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with Union of nested dataclasses: Does not validate against any of the Union subtypes ... Not a valid subclass of

1 participant