Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions jsonargparse/_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,17 +183,16 @@ def __call__(self, parser, namespace, value, option_string=None):
valid_flags = {"": None, "skip_default": "skip_default", "skip_unset": "skip_unset"} | deprecated_valid_flags
if ruamel_support:
valid_flags["comments"] = "with_comments"
if value is not None:
flags = value[0].split(",")
invalid_flags = [f for f in flags if f not in valid_flags]
if len(invalid_flags) > 0:
raise argument_error(f'Invalid option "{invalid_flags[0]}" for {option_string}')
for flag in [f for f in flags if f != ""]:
mapped = valid_flags[flag]
if deprecated_skip_null(flag):
kwargs["skip_unset"] = True
else:
kwargs[mapped] = True
flags = value[0].split(",")
invalid_flags = [f for f in flags if f not in valid_flags]
if len(invalid_flags) > 0:
raise argument_error(f'Invalid option "{invalid_flags[0]}" for {option_string}')
for flag in [f for f in flags if f != ""]:
mapped = valid_flags[flag]
if deprecated_skip_null(flag):
kwargs["skip_unset"] = True
else:
kwargs[mapped] = True
while hasattr(parser, "parent_parser"):
kwargs["key"] = parser.subcommand if kwargs["key"] is None else parser.subcommand + "." + kwargs["key"]
parser = parser.parent_parser
Expand Down
2 changes: 1 addition & 1 deletion jsonargparse_tests/test_postponed_annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def function_nested_partial_forward_ref(
p1: List[List["DefinedClass"]],
p2: "Undefined", # type: ignore[name-defined] # noqa: F821
):
pass
pass # pragma: no cover


def test_nested_partial_forward_ref(parser):
Expand Down
Loading