[pull] main from w-ahmad:main#26
Merged
Merged
Conversation
Signed-off-by: Godly Alias <godlyalias@microsoft.com>
Signed-off-by: Godly Alias <godlyalias@microsoft.com>
Signed-off-by: Godly Alias <godlyalias@microsoft.com>
Signed-off-by: Godly Alias <godlyalias@microsoft.com>
Signed-off-by: Godly Alias <godlyalias@microsoft.com>
Signed-off-by: Godly Alias <godlyalias@microsoft.com>
Address PR review feedback: change the _dragRectangleCanvas and _isDragSelecting internal fields into internal properties (DragRectangleCanvas and IsDragSelecting) with private setters, following the codebase convention for internal members. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve conflicts in src/TableView.cs (OnApplyTemplate: keep drag rectangle template-child wiring alongside upstream's null-conditional ScrollViewer.Loaded subscription) and src/TableView.Properties.cs (keep both ShowDragRectangle and ForceRowOrCellSelectionOnContextRequested properties). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes CI build break: the internal fields _isDragSelecting and _dragRectangleCanvas were converted to internal properties (IsDragSelecting, DragRectangleCanvas), so update the test references accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Following the change of ShowDragRectangle's default value to true, update the default-value assertions accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ngle Feature/drag selection rectangle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )