fix(setSize): reset position when setSize#350
Open
binvb wants to merge 2 commits into
Open
Conversation
|
Hi @max-mapper, I think it is a useful function to be able to trigger the repositioning yourself. |
Collaborator
|
Sure. @binvb can you rebase/merge master? |
4 tasks
afonsojramos
added a commit
to gitify-app/menubar
that referenced
this pull request
May 10, 2026
Extracts the position calculation out of `showWindow` into a focused, synchronous `positionWindow` arrow field, and hooks it to the browser window's `resize` event. After `mb.window.setSize(...)` the window re-anchors to the tray, fixing the upstream issue where part of the window ended up clipped by the taskbar. `showWindow` now caches the latest tray bounds before calling `positionWindow`, keeping the cache as the single source of truth that the resize handler reads from. Closes the gap from upstream max-mapper#350 by @binvb / max-mapper#349.
afonsojramos
added a commit
to gitify-app/menubar
that referenced
this pull request
May 11, 2026
Extracts the position calculation out of `showWindow` into a focused, synchronous `positionWindow` arrow field, and hooks it to the browser window's `resize` event. After `mb.window.setSize(...)` the window re-anchors to the tray, fixing the upstream issue where part of the window ended up clipped by the taskbar. `showWindow` now caches the latest tray bounds before calling `positionWindow`, keeping the cache as the single source of truth that the resize handler reads from. Closes the gap from upstream max-mapper#350 by @binvb / max-mapper#349.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#349