Commit 20ceca1
fix(skills): approve on trivial-change-skip when prior bot issues are resolved (#145)
## Summary
- Fix the review skill's trivial-change-skip path to approve when prior
bot-flagged issues are resolved, instead of unconditionally skipping
approval.
## Evidence
**Run:**
[23976359110](https://github.com/max-sixty/worktrunk/actions/runs/23976359110)
(`tend-review` on `docs/cmux-integration`, PR max-sixty/worktrunk#1907)
The bot reviewed the PR and flagged a sync-test issue (COMMENTED
review). It then pushed a fix commit itself. On the next run, the
trivial-change-skip path fired correctly (only 4 lines changed in 1
file), but the instruction "do not submit a new approval — the existing
review stands" meant the PR was left with zero approvals despite all
concerns being addressed.
**Classification:** Structural — the old instruction deterministically
prevents approval on the trivial-change-skip path regardless of the
prior review's state. Replaying this scenario would always produce the
same result.
**Root cause:** The trivial-change-skip instruction treated all prior
reviews as equivalent. A prior APPROVE review doesn't need refreshing,
but a prior COMMENT review that flagged issues does need an APPROVE once
those issues are fixed.
## Gate assessment
| Gate | Assessment |
|---|---|
| Confidence | Structural failure, 1 clear occurrence — sufficient per
gate rules |
| Magnitude | Targeted fix (rewording 1 paragraph, no new sections) —
normal evidence bar |
| Historical evidence | No prior occurrences in tracking issue #133 |
## Change
Rewrote the trivial-change-skip paragraph to: resolve threads first
(step 7), then check whether the prior bot review was a COMMENT with
now-addressed issues → approve. Otherwise, keep the existing "do not
submit a new review" behavior.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: continuous-bot <269947486+continuous-bot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent bc88670 commit 20ceca1
1 file changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| |||
0 commit comments