Skip to content

Commit fe63a29

Browse files
fix(review): re-unbreak /review slash command poisoned by PR #226 regression
PR #226 (`fix(ci-runner): filter CI polling by run URL, not workflow name`) reintroduced the exact poisoned-text regression that PR #234 fixed. Its diff on plugins/tend-ci-runner/skills/review/SKILL.md and plugins/tend-ci-runner/skills/running-in-ci/SKILL.md reverted the CI-polling comment from the PR #234 wording back to the pre-#234 wording containing `` `if \!` ``, which the slash-command preprocessor scans and exec's as bash. Since #226 merged at 2026-04-11 15:01:22 UTC, every `/review` invocation has failed identically with the 5-line trace: queue/dequeue, command-caveat, command-name, local-command-stderr, then nothing. Three tend-review runs in this hour's window (PRs #240, #241, #242) all produced that exact trace and posted zero reviews. Rephrase the CI-polling comment in both files to avoid any `\!` adjacent to a backtick. The guidance is unchanged. Matches the wording that PR #234 already merged successfully — this is a straight restoration of that fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3a95e12 commit fe63a29

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

plugins/tend-ci-runner/skills/review/SKILL.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,9 +293,10 @@ the job name (`review`), which does not match `$GITHUB_WORKFLOW` (`tend-review`)
293293

294294
```bash
295295
# Run with Bash tool's run_in_background: true.
296-
# Use `||` rather than `if !` — the Bash tool escapes `!` as `\!`, which
297-
# prevents bash from recognizing the pipeline-negation reserved word and
298-
# leaves the loop stuck until the 10-minute timeout.
296+
# Use `||` rather than `if`-based negation. The Bash tool escapes the
297+
# exclamation mark to a literal backslash-exclamation, which prevents bash
298+
# from recognizing the pipeline-negation reserved word and leaves the loop
299+
# stuck until the 10-minute timeout.
299300
for i in $(seq 1 10); do
300301
sleep 60
301302
gh pr checks <number> --required 2>&1 \

plugins/tend-ci-runner/skills/running-in-ci/SKILL.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,10 @@ background task completes you will be notified — check the result and take any
144144
# show as "pending" since it IS the running job. Watching yourself deadlocks.
145145
# Match on the run URL, not the check name: `gh pr checks` shows the job name
146146
# (e.g. "review"), which does not match $GITHUB_WORKFLOW ("tend-review").
147-
# Use `||` rather than `if !` — the Bash tool escapes `!` as `\!`, which
148-
# prevents bash from recognizing the pipeline-negation reserved word and
149-
# leaves the loop stuck until the 10-minute timeout.
147+
# Use `||` rather than `if`-based negation. The Bash tool escapes the
148+
# exclamation mark to a literal backslash-exclamation, which prevents bash
149+
# from recognizing the pipeline-negation reserved word and leaves the loop
150+
# stuck until the 10-minute timeout.
150151
for i in $(seq 1 10); do
151152
sleep 60
152153
gh pr checks <number> --required 2>&1 | grep -v "/runs/$GITHUB_RUN_ID/" | grep -q 'pending\|queued\|in_progress' || {

0 commit comments

Comments
 (0)