fix(running-in-ci): make commit-SHA permalink rule unmissable#240
Merged
Conversation
Four `blob/main/...#L42` link references shipped across two sessions in one hour on max-sixty/worktrunk issue #2075 — on top of one prior occurrence on issue #2072 — despite the existing `Prefer permalinks` guidance. Rephrase the rule in imperative form, point to `git rev-parse HEAD` as the source of the SHA, and split the bullet so the file-level and line-reference cases can't be conflated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tend-agent
pushed a commit
that referenced
this pull request
Apr 11, 2026
…ression PR #226 (`fix(ci-runner): filter CI polling by run URL, not workflow name`) reintroduced the exact poisoned-text regression that PR #234 fixed. Its diff on plugins/tend-ci-runner/skills/review/SKILL.md and plugins/tend-ci-runner/skills/running-in-ci/SKILL.md reverted the CI-polling comment from the PR #234 wording back to the pre-#234 wording containing `` `if \!` ``, which the slash-command preprocessor scans and exec's as bash. Since #226 merged at 2026-04-11 15:01:22 UTC, every `/review` invocation has failed identically with the 5-line trace: queue/dequeue, command-caveat, command-name, local-command-stderr, then nothing. Three tend-review runs in this hour's window (PRs #240, #241, #242) all produced that exact trace and posted zero reviews. Rephrase the CI-polling comment in both files to avoid any `\!` adjacent to a backtick. The guidance is unchanged. Matches the wording that PR #234 already merged successfully — this is a straight restoration of that fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthen the running-in-ci skill's guidance on permalinks for line references, after four fresh occurrences of
blob/main/...#L42line links in a single hour onmax-sixty/worktrunkissue #2075, on top of one prior occurrence on issue #2072. The current wording ("Prefer permalinks...") is a soft preference buried in a bullet that co-lists theblob/main/...file-level form and theblob/<sha>/...#L42line-reference form inside parentheses. Under cognitive load, the model anchors on the first form and pastes#L42ontoblob/main/...— producing a link that stays valid but silently starts pointing at different code once the surrounding file changes.Evidence
Past hour on
max-sixty/worktrunk— 4 occurrences across 2 sessions, all on issue #2075 ("Allow wt step aliases to change the parent shell's directory"):Run 24285060091 —
tend-triageon the newly-opened #2075. Session242fb543-d70d-47e7-a0cd-5e3ce6ced53d.jsonl. The posted comment linked toblob/main/src/config/user/sections.rs#L528.Run 24285659522 —
tend-mentionon #2075 (response to max-sixty's question about the implicit option). Sessionfa2b09a6-9e74-4997-9fb2-967990c765d1.jsonl. The comment linked three files viablob/main/...#L:blob/main/src/commands/for_each.rs#L214blob/main/src/commands/alias.rs#L282-L296blob/main/src/output/global.rs#L227Historical evidence from tracking issue #133 — 1 prior occurrence:
tend-triageonmax-sixty/worktrunk#2072. Sessionc897d54c-17c7-44c1-a6dc-426c8813ce4b.jsonl. Comment linkedblob/main/src/help.rs#L157-L162to the very line that PR #2073 then rewrote (eprint\!→print\!).Cumulative: 5 occurrences across 3 sessions and 2 issues.
Gate assessment
blob/main/...(for file-level) withblob/main/...#L42(for lines). A sharper imperative removes that ambiguity. The replay test: if you replayed the same "paste a line ref into a comment" scenario 10 times, the current guidance would hit the same ambiguity every time — it's not a random model lapse.The change
Prose sentence — from "Prefer permalinks (commit SHA URLs) over branch-based links for line references" (soft) to "Any link containing
#Lmust use a commit SHA, neverblob/main/...#L42" (hard rule, withgit rev-parse HEADnamed as the SHA source so the bot has an obvious next step rather than rationalizingmainas "I don't have a SHA handy").Bullet list — from the single co-listed
Filesbullet to two separate bullets, so the#L42case can't be skimmed past:#Lanchor):blob/main/src/foo.rsis fineblob/<sha>/src/foo.rs#L42— commit SHA required, neverblob/main/...#L42Test plan
tend-triageandtend-mentionruns that reference specific lines useblob/<sha>/...#Lform.