skills(running-tend): scope data-loss review hold to the diff, not the file#3457
Open
worktrunk-bot wants to merge 2 commits into
Open
skills(running-tend): scope data-loss review hold to the diff, not the file#3457worktrunk-bot wants to merge 2 commits into
worktrunk-bot wants to merge 2 commits into
Conversation
Owner
|
cut verbosity of change by 70%, rewrite existing docs rather than patching |
f26cba3 to
7e7bdb2
Compare
Collaborator
Author
|
Done — force-pushed a rewrite. Instead of adding a new subsection, I rewrote the existing "Both directions matter" paragraph in place; the change is now +9/−4 (net +5 lines) versus the previous +20. Both the source-proximity and structured-config cases are kept, just folded into one paragraph. |
Owner
|
still too verbose; this is not a super complex thing, it doesn't need examples. Thank you |
Collaborator
Author
|
Trimmed to four lines, no examples — just the source-proximity vs. structured-entry rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines the data-loss-surface review hold so it keys on what the diff touches, not on unrelated contents of the same file.
In #3453 I held a creation-only change to
plugins/worktrunk/hooks/hooks.jsonpurely because that file also ships theWorktreeRemovehook (wt remove), even though the diff never touched the removal path. @max-sixty flagged that as overly conservative:The old "edits a file that already contains one" trigger fired on mere co-location. This adds a "Scope the hold to the diff, not the file" subsection that splits the two cases the trigger was conflating:
src/git/remove.rs) — still hold on proximity, because an edit near the force-delete path can change its behavior at a distance without the destructive line appearing in the diff. That rationale (the original "Both directions matter" note) is preserved.hooks.json's separate hook objects, alias tables) — hold only when the diff touches the destructive entry itself. Editing theWorktreeCreatecommand can't change what the separateWorktreeRemovehook does, so an edit confined to a non-destructive entry no longer warrants a hold.The distinction is whether an edit can reach a destruction path structurally, which is exactly the "does the code actually touch a data-destruction path" test.
Separate PR from the code change it came out of, per the skill-overlay convention. Triggered from #3453 (comment).