chore: drop the NEXTEST_NO_INPUT_HANDLER workaround#3482
Open
max-sixty wants to merge 4 commits into
Open
Conversation
CLAUDE.md told every session to run the full pre-merge gate (full nextest suite + lints + doctests + rustdoc) before each commit, which is redundant with the gate wt merge runs itself and with CI's required full matrix. Describe what the commands do and when they run automatically; leave the decision of what to run during iteration to the session. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # CLAUDE.md
nextest#2878 (SIGTTOU suspension when a test spawns an interactive shell) was fixed in nextest 0.9.118; pin that as the required floor in .config/nextest.toml instead of threading the env var through the insta hook, CI, and docs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
worktrunk-bot
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextest#2878 (the run suspending with SIGTTOU when a test spawns an interactive shell, as the
shell-integration-testsfeature does) was fixed in nextest 0.9.118, so theNEXTEST_NO_INPUT_HANDLER=1workaround threaded through the insta hook, CI, and the test docs is obsolete. Verified on nextest 0.9.132: the shell-wrapper tests run to completion under a real PTY without the variable..config/nextest.tomlnow pinsnextest-version = "0.9.118", so an older nextest fails with a clear version error instead of suspending mid-run.