avoid try/catch and reuse computations in ExplicitSafetyFilter#22
Open
baggepinnen wants to merge 3 commits intomaxhcohen:mainfrom
Open
avoid try/catch and reuse computations in ExplicitSafetyFilter#22baggepinnen wants to merge 3 commits intomaxhcohen:mainfrom
baggepinnen wants to merge 3 commits intomaxhcohen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
k, that is, no need to use try/catch to figure out how many arguments the user-provided function has.Lgh, Lfh, kdonce instead of several times.With these improvements as well as using static arrays in the segway example, the call to
simulategoes from2.000 ms (63246 allocations: 1.70 MiB)to
104.959 μs (2218 allocations: 106.91 KiB)