This repository was archived by the owner on May 9, 2026. It is now read-only.
Add simpleClient into the WBK function#141
Merged
Merged
Conversation
ogroppo
commented
Mar 25, 2026
maxlath
reviewed
Mar 27, 2026
ogroppo
commented
Mar 27, 2026
| readonly getEntitiesFromSitelinks: (options: GetEntitiesFromSitelinksOptions) => Promise<WbGetEntitiesResponse> | ||
| readonly sparqlQuery: (sparql: string) => Promise<SparqlResults> | ||
| readonly getReverseClaims: (options: GetReverseClaimsOptions) => Promise<SparqlResults> | ||
| } |
Contributor
Author
There was a problem hiding this comment.
inferred type at the end of file
Contributor
Author
|
Hi @maxlath do you have more comments on this PR? |
Owner
maxlath
reviewed
Apr 15, 2026
ogroppo
commented
Apr 17, 2026
Contributor
Author
ogroppo
left a comment
ogroppo
left a comment
There was a problem hiding this comment.
All comments addressed
Contributor
Author
|
Hi @maxlath anything else you need me to add? when can we aim to get this published? |
…ed structure and functionality
…initions for clarity
Owner
|
Merged and published in I was waiting for this PR to be closed to start the repository transfer to Codeberg (where I already moved my other repositories): please open any further PR there https://codeberg.org/maxlath/wikibase-sdk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137