Fix keyboard options traversal to always follow visual order#140
Open
RisPNG wants to merge 1 commit intomaxmarcon:mainfrom
Open
Fix keyboard options traversal to always follow visual order#140RisPNG wants to merge 1 commit intomaxmarcon:mainfrom
RisPNG wants to merge 1 commit intomaxmarcon:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, me again, I use this component a lot in my production system, so I've encountered quirks, bugs, and things that can be improved. Since I have a bit of free time to contribute today due to Chinese New Years, hence the multiple issue reports and PRs. However, I do I believe they are all valid to be considered.
Issue refer to #139.
In the current implementation, the keyboard navigation always follows data indices (0, 1, 2, 3...) even if the visual order is different since they can be modified through the internal CSS options.
To fix this, I added a visualOrder variable in the js that fetches the visual order on the client side to be used by keydown and selectable functions.
Here is the video after the fix:
Screencast.From.2026-02-20.19-20-12.mp4