fixup! STF-322: Add tests for transport-failure retry

Author: oschwald

src/test/java/com/maxmind/geoip2/WebServiceClientTest.java

@@ -50,6 +50,8 @@
 import java.util.List;
 import org.hamcrest.CoreMatchers;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -627,7 +629,17 @@ public void testNoRetryOn4xx() {
         wireMock.verify(1, getRequestedFor(urlEqualTo(url)));
     }
 
+    // Disabled on Windows: when WireMock immediately RSTs a fresh connection,
+    // the Windows TCP stack can cause the JDK's h2c upgrade probe to fail
+    // before negotiation completes, prompting the JDK to retry the request
+    // as plain HTTP/1.1. The HTTP/1.1 path then triggers the JDK's own
+    // idempotent-GET retry inside HttpClient.send(), producing two wire
+    // requests where the test expects one. This is platform-specific JDK
+    // behavior we cannot disable from application code; the equivalent
+    // POST-based test in minfraud-api-java is unaffected because the JDK
+    // does not internally retry non-idempotent requests.
     @Test
+    @DisabledOnOs(OS.WINDOWS)
     public void testMaxRetriesZeroDisablesRetry() {
         String url = "/geoip/v2.1/insights/1.2.3.4";
         wireMock.stubFor(get(urlEqualTo(url))
@@ -646,7 +658,11 @@ public void testMaxRetriesZeroDisablesRetry() {
         wireMock.verify(1, getRequestedFor(urlEqualTo(url)));
     }
 
+    // Disabled on Windows for the same reason as testMaxRetriesZeroDisablesRetry:
+    // the JDK's internal idempotent-GET retry can stack on top of our retry
+    // loop on the HTTP/1.1 fallback path, multiplying wire counts.
     @Test
+    @DisabledOnOs(OS.WINDOWS)
     public void testRetriesExhausted() {
         String url = "/geoip/v2.1/insights/1.2.3.4";
         wireMock.stubFor(get(urlEqualTo(url))