Skip to content

Commit b9536e4

Browse files
oschwaldclaude
andcommitted
Update remaining GeoIP2 product prose to GeoIP
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 37399d7 commit b9536e4

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

CLAUDE.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ minFraud fraud detection web services:
1616
minFraud accuracy
1717

1818
The library provides both synchronous and asynchronous methods, supports ASP.NET
19-
Core dependency injection, and integrates deeply with MaxMind's GeoIP2 library
19+
Core dependency injection, and integrates deeply with MaxMind's GeoIP library
2020
for IP intelligence.
2121

2222
**Key Technologies:**
@@ -79,7 +79,7 @@ MaxMind.MinFraud/
7979
│ └── CustomInputs.cs # Builder pattern for custom fields
8080
├── Response/ # Response models (Score, Insights, Factors)
8181
│ ├── Score.cs # Base response (RiskScore, Id, Warnings)
82-
│ ├── Insights.cs # Extends Score, adds GeoIP2 & device data
82+
│ ├── Insights.cs # Extends Score, adds GeoIP & device data
8383
│ ├── Factors.cs # Extends Insights, adds RiskScoreReasons
8484
│ └── IPAddress.cs, Device.cs, Email.cs, etc.
8585
├── Util/ # JSON converters and helpers
@@ -132,13 +132,13 @@ Score (base)
132132
- Each level adds more detail without breaking compatibility
133133
- Interface-based polymorphism for `IIPAddress` (Score uses minimal, Insights
134134
uses full)
135-
- Response models inherit from GeoIP2 models (e.g.,
135+
- Response models inherit from GeoIP models (e.g.,
136136
`IPAddress : InsightsResponse`)
137137
- All response properties are init-only with default empty objects (never null)
138138

139-
#### 3. **GeoIP2 Integration via Inheritance**
139+
#### 3. **GeoIP Integration via Inheritance**
140140

141-
minFraud response models inherit from and extend GeoIP2 models:
141+
minFraud response models inherit from and extend GeoIP models:
142142

143143
```csharp
144144
public sealed class IPAddress : InsightsResponse, IIPAddress
@@ -152,9 +152,9 @@ public sealed class IPAddress : InsightsResponse, IIPAddress
152152

153153
**Implications:**
154154

155-
- Changes to GeoIP2 models affect minFraud responses
156-
- When adding fields, check if they belong in GeoIP2 or minFraud layer
157-
- Use GeoIP2 patterns for location-related data
155+
- Changes to GeoIP models affect minFraud responses
156+
- When adding fields, check if they belong in GeoIP or minFraud layer
157+
- Use GeoIP patterns for location-related data
158158

159159
#### 4. **Email Address Normalization**
160160

@@ -298,8 +298,8 @@ back to JSON and match the original structure.
298298

299299
### Adding New Fields to Existing Response Models
300300

301-
1. **Determine if field is GeoIP2 or minFraud-specific**
302-
- GeoIP2: Location data, ISP, traits, etc. → Add to GeoIP2 library first
301+
1. **Determine if field is GeoIP or minFraud-specific**
302+
- GeoIP: Location data, ISP, traits, etc. → Add to GeoIP library first
303303
- minFraud: Risk, device intelligence, email intelligence → Add here
304304

305305
2. **Add property** with init-only setter:
@@ -509,12 +509,12 @@ Requires `EnumMemberValueConverter<T>` in JSON options.
509509
- Provides base models for response classes (InsightsResponse, Location, Traits,
510510
etc.)
511511
- minFraud responses inherit from and extend these models
512-
- Changes to GeoIP2 models can affect minFraud API surface
512+
- Changes to GeoIP models can affect minFraud API surface
513513

514514
**System.Text.Json**
515515

516516
- Modern JSON serialization (not Newtonsoft.Json)
517-
- Requires custom converters for enums, IP addresses, GeoIP2 types
517+
- Requires custom converters for enums, IP addresses, GeoIP types
518518
- Uses snake_case naming via `[JsonPropertyName]` attributes
519519

520520
**Microsoft.Extensions.Options**

MaxMind.MinFraud/Response/Insights.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace MaxMind.MinFraud.Response
88
public record Insights : Score
99
{
1010
/// <summary>
11-
/// An object containing GeoIP2 and minFraud Insights information about
11+
/// An object containing GeoIP and minFraud Insights information about
1212
/// the IP address.
1313
/// </summary>
1414
[JsonPropertyName("ip_address")]

MaxMind.MinFraud/WebServiceClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public async Task<Factors> FactorsAsync(Transaction transaction)
129129
throw new MinFraudException(
130130
$"WithLocales returned {withLocales.GetType().FullName} instead of "
131131
+ $"the expected {typeof(Response.IPAddress).FullName}. "
132-
+ "This may indicate an incompatible GeoIP2 library version.");
132+
+ "This may indicate an incompatible GeoIP library version.");
133133
}
134134
return factors with { IPAddress = ipAddress };
135135
}
@@ -151,7 +151,7 @@ public async Task<Insights> InsightsAsync(Transaction transaction)
151151
throw new MinFraudException(
152152
$"WithLocales returned {withLocales.GetType().FullName} instead of "
153153
+ $"the expected {typeof(Response.IPAddress).FullName}. "
154-
+ "This may indicate an incompatible GeoIP2 library version.");
154+
+ "This may indicate an incompatible GeoIP library version.");
155155
}
156156
return insights with { IPAddress = ipAddress };
157157
}

0 commit comments

Comments
 (0)