Use modern Java features

Author: oschwald

src/main/java/com/maxmind/minfraud/request/CustomInputs.java

@@ -3,7 +3,6 @@
 import com.fasterxml.jackson.annotation.JsonAnyGetter;
 import com.maxmind.minfraud.AbstractModel;
 
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.regex.Pattern;
@@ -17,7 +16,7 @@ public final class CustomInputs extends AbstractModel {
     private final Map<String, Object> inputs;
 
     private CustomInputs(Builder builder) {
-        inputs = Collections.unmodifiableMap(new HashMap<>(builder.inputs));
+        inputs = Map.copyOf(builder.inputs);
     }
 
     /**

src/main/java/com/maxmind/minfraud/request/Email.java

@@ -22,7 +22,7 @@ public final class Email extends AbstractModel {
     private static final Map<String, String> typoDomains;
 
     static {
-        HashMap<String, String> m = new HashMap<String, String>() {{
+        HashMap<String, String> m = new HashMap<>() {{
             // gmail.com
             put("35gmai.com", "gmail.com");
             put("636gmail.com", "gmail.com");

src/test/java/com/maxmind/minfraud/request/EmailTest.java

@@ -29,7 +29,7 @@ public void testMultipleAtAddress() {
 
     @Test
     public void testAddressWithNoValidation() {
-        Map<String, String> addresses = new HashMap<String, String>() {{
+        Map<String, String> addresses = new HashMap<>() {{
             put("test", null);
             put("@test", "test");
             put("test@", null);

src/test/java/com/maxmind/minfraud/request/RequestTestHelper.java

@@ -7,7 +7,6 @@
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
-import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Paths;
 import java.time.ZonedDateTime;
@@ -153,7 +152,7 @@ private static Transaction makeTransaction(Email e) throws Exception {
     public static String readJsonFile(String name) throws IOException, URISyntaxException {
         URL resource = RequestTestHelper.class
                 .getResource("/test-data/" + name + ".json");
-        return new String(Files.readAllBytes(Paths.get(resource.toURI())), StandardCharsets.UTF_8);
+        return Files.readString(Paths.get(resource.toURI()));
     }
 
     public static void verifyRequestFor(String service, String jsonFile) throws IOException, URISyntaxException {

src/test/java/com/maxmind/minfraud/response/IpAddressTest.java

@@ -44,7 +44,7 @@ public void testIpAddress() throws Exception {
                         .finish()
         );
 
-        assertEquals("IP risk", new Double(99), address.getRisk());
+        assertEquals("IP risk", Double.valueOf(99), address.getRisk());
         assertEquals("correct local time", time, address.getLocation().getLocalTime());
         assertEquals("1.2.0.0/16", address.getTraits().getNetwork().toString());
         assertTrue("isHighRisk", address.getCountry().isHighRisk());