Remove deprecated code

Most notable, `WebServiceClient` no longer implements `Closeable`.

Author: oschwald

CHANGELOG.md

@@ -5,6 +5,16 @@ CHANGELOG
 ------------------
 
 * This library is now a Java module.
+* Removed deprecated `last4Digits` method on `CreditCard.Builder` and
+  `getLast4Digits` method on `CreditCard`. Use `lastDigits` and
+  `getLastDigits` instead.
+* Removed deprecated `connectTimeout(int)`, `readTimeout(int)`, and
+  `proxy(Proxy)` on `WebServiceClient.Builder`. Use
+  `connectTimeout(Duration)`, `requestTimeout(Duration)`, and
+  `proxy(ProxySelector)` instead.
+* `WebServiceClient` no longer implements `Closeable` and the `Close`
+  method has been removed. This method was deprecated when the library
+  switched to using `java.net.http.HttpClient`.
 
 2.2.0 (2022-10-31)
 ------------------

src/main/java/com/maxmind/minfraud/WebServiceClient.java

@@ -14,11 +14,8 @@
 import com.maxmind.minfraud.response.FactorsResponse;
 import com.maxmind.minfraud.response.InsightsResponse;
 import com.maxmind.minfraud.response.ScoreResponse;
-import java.io.Closeable;
 import java.io.IOException;
 import java.io.InputStream;
-import java.net.InetSocketAddress;
-import java.net.Proxy;
 import java.net.ProxySelector;
 import java.net.URI;
 import java.net.URISyntaxException;
@@ -37,7 +34,7 @@
 /**
  * Client for MaxMind minFraud Score, Insights, and Factors
  */
-public final class WebServiceClient implements Closeable {
+public final class WebServiceClient {
     private static final String pathBase = "/minfraud/v2.0/";
     private static final String userAgent = "minFraud-API/"
         + WebServiceClient.class.getPackage().getImplementationVersion()
@@ -118,17 +115,6 @@ public Builder(int accountId, String licenseKey) {
             this.licenseKey = licenseKey;
         }
 
-        /**
-         * @param val Timeout in milliseconds to establish a connection to the
-         *            web service. There is no timeout by default.
-         * @return Builder object
-         * @deprecated Use connectTimeout(Duration) instead
-         */
-        @Deprecated
-        public WebServiceClient.Builder connectTimeout(int val) {
-            return connectTimeout(Duration.ofMillis(val));
-        }
-
         /**
          * @param val Timeout duration to establish a connection to the web
          *            service. There is no timeout by default.
@@ -181,17 +167,6 @@ public WebServiceClient.Builder locales(List<String> val) {
             return this;
         }
 
-        /**
-         * @param val readTimeout in milliseconds to read data from an
-         *            established connection to the web service. There is no
-         *            timeout by default.
-         * @return Builder object
-         * @deprecated Use requestTimeout(Duration) instead
-         */
-        @Deprecated
-        public WebServiceClient.Builder readTimeout(int val) {
-            return requestTimeout(Duration.ofMillis(val));
-        }
 
         /**
          * @param val Request timeout duration. here is no timeout by default.
@@ -202,18 +177,6 @@ public Builder requestTimeout(Duration val) {
             return this;
         }
 
-        /**
-         * @param val the proxy to use when making this request.
-         * @return Builder object
-         * @deprecated Use proxy(ProxySelector)
-         */
-        @Deprecated
-        public Builder proxy(Proxy val) {
-            if (val != null && val != Proxy.NO_PROXY) {
-                proxy = ProxySelector.of((InetSocketAddress) val.address());
-            }
-            return this;
-        }
 
         /**
          * @param val the proxy to use when making this request.
@@ -507,14 +470,6 @@ private void exhaustBody(HttpResponse<InputStream> response) throws HttpExceptio
         }
     }
 
-    /**
-     * @deprecated Closing is no longer necessary with java.net.http.HttpClient.
-     */
-    @Override
-    @Deprecated
-    public void close() throws IOException {
-    }
-
     @Override
     public String toString() {
         return "WebServiceClient{"

src/main/java/com/maxmind/minfraud/request/CreditCard.java

@@ -1,6 +1,5 @@
 package com.maxmind.minfraud.request;
 
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.maxmind.minfraud.AbstractModel;
 import java.util.regex.Pattern;
@@ -73,18 +72,6 @@ public CreditCard.Builder issuerIdNumber(String number) {
             return this;
         }
 
-        /**
-         * @param digits The last two or four digits of the credit card number.
-         * @return The builder object.
-         * @throws IllegalArgumentException when number is not a two or four digit
-         *                                  string.
-         * @deprecated Use lastDigits instead.
-         */
-        @Deprecated
-        public CreditCard.Builder last4Digits(String digits) {
-            return this.lastDigits(digits);
-        }
-
         /**
          * @param digits The last two or four digits of the credit card number.
          * @return The builder object.
@@ -226,16 +213,6 @@ public String getIssuerIdNumber() {
         return issuerIdNumber;
     }
 
-    /**
-     * @return The last two or four digits of the credit card number.
-     * @deprecated use {@code getLastDigits}
-     */
-    @Deprecated
-    @JsonIgnore
-    public String getLast4Digits() {
-        return this.getLastDigits();
-    }
-
     /**
      * @return The last two or four digits of the credit card number.
      */