Merge pull request #103 from maxmind/greg/cc-is-business

Add support for /credit_card/is_business output

Author: horgh

CHANGELOG.md

@@ -1,6 +1,14 @@
 CHANGELOG
 =========
 
+1.13.0
+-------------------
+
+* Added support for the new credit card output `/credit_card/is_business`.
+  This indicates whether the card is a business card. It may be accessed via
+  `response.getCreditCard().isBusiness()` on the minFraud Insights and Factors
+  response objects.
+
 1.12.0 (2020-03-26)
 -------------------
 

pom.xml

@@ -69,6 +69,13 @@
             <artifactId>httpclient</artifactId>
             <version>4.5.12</version>
         </dependency>
+        <dependency>
+            <!-- httpclient pulls this in. We pull in a newer version
+            because of a security issue in 1.11 -->
+            <groupId>commons-codec</groupId>
+            <artifactId>commons-codec</artifactId>
+            <version>1.13</version>
+        </dependency>
         <!--
             commons-validator 1.6 depends on an older version of
             commons-beanutils with a CVE. So add a direct dependency on the

src/main/java/com/maxmind/minfraud/response/CreditCard.java

@@ -10,6 +10,7 @@ public final class CreditCard extends AbstractModel {
     private final Issuer issuer;
     private final String brand;
     private final String country;
+    private final Boolean isBusiness;
     private final Boolean isIssuedInBillingAddressCountry;
     private final Boolean isPrepaid;
     private final Boolean isVirtual;
@@ -29,9 +30,26 @@ public CreditCard(
             issuer, type);
     }
 
+    // This method is for backwards compatibility. We should remove it when we
+    // do a major release.
+    public CreditCard(
+            String brand,
+            String country,
+            Boolean isIssuedInBillingAddressCountry,
+            Boolean isPrepaid,
+            Boolean isVirtual,
+            Issuer issuer,
+            String type
+    ) {
+        this(brand, country, false, isIssuedInBillingAddressCountry, isPrepaid,
+            isVirtual, issuer, type);
+    }
+
+
     public CreditCard(
             @JsonProperty("brand") String brand,
             @JsonProperty("country") String country,
+            @JsonProperty("is_business") Boolean isBusiness,
             @JsonProperty("is_issued_in_billing_address_country") Boolean isIssuedInBillingAddressCountry,
             @JsonProperty("is_prepaid") Boolean isPrepaid,
             @JsonProperty("is_virtual") Boolean isVirtual,
@@ -40,6 +58,7 @@ public CreditCard(
     ) {
         this.brand = brand;
         this.country = country;
+        this.isBusiness = isBusiness;
         this.isIssuedInBillingAddressCountry = isIssuedInBillingAddressCountry;
         this.isPrepaid = isPrepaid;
         this.isVirtual = isVirtual;
@@ -77,6 +96,15 @@ public String getCountry() {
         return country;
     }
 
+    /**
+     * @return True if the card is a business card. False if not a business
+     * card. If the IIN was not provided or is unknown, null will be returned.
+     */
+    @JsonProperty("is_business")
+    public Boolean isBusiness() {
+        return isBusiness;
+    }
+
     /**
      * @return True if the country of the billing address matches the country
      * of the majority of customers using that IIN. In cases where the

src/test/java/com/maxmind/minfraud/response/CreditCardTest.java

@@ -20,6 +20,7 @@ public void testCreditCard() throws Exception {
                         .end()
                         .put("brand", "Visa")
                         .put("country", "US")
+                        .put("is_business", true)
                         .put("is_issued_in_billing_address_country", true)
                         .put("is_prepaid", true)
                         .put("is_virtual", true)
@@ -32,6 +33,7 @@ public void testCreditCard() throws Exception {
         assertEquals("US", cc.getCountry());
         assertEquals("Visa", cc.getBrand());
         assertEquals("credit", cc.getType());
+        assertTrue(cc.isBusiness());
         assertTrue(cc.isPrepaid());
         assertTrue(cc.isVirtual());
         assertTrue(cc.isIssuedInBillingAddressCountry());

src/test/java/com/maxmind/minfraud/response/InsightsResponseTest.java

@@ -37,6 +37,7 @@ public void testInsights() throws Exception {
                         .end()
                         .end()
                         .startObjectField("credit_card")
+                        .put("is_business", true)
                         .put("is_prepaid", true)
                         .end()
                         .startObjectField("shipping_address")
@@ -61,6 +62,7 @@ public void testInsights() throws Exception {
         assertEquals("disposition", "accept", insights.getDisposition().getAction());
         assertEquals("email domain first seen", LocalDate.parse("2014-02-03"), insights.getEmail().getDomain().getFirstSeen());
         assertEquals("correct country ISO", "US", insights.getIpAddress().getCountry().getIsoCode());
+        assertTrue("correct credit card is business", insights.getCreditCard().isBusiness());
         assertTrue("correct credit card prepaid", insights.getCreditCard().isPrepaid());
         assertTrue("correct shipping address is in IP country", insights.getShippingAddress().isInIpCountry());
         assertTrue("correct billing address is in IP country", insights.getBillingAddress().isInIpCountry());

src/test/resources/test-data/factors-response.json

@@ -115,6 +115,7 @@
     },
     "brand": "Visa",
     "country": "US",
+    "is_business": true,
     "is_issued_in_billing_address_country": true,
     "is_prepaid": true,
     "type": "credit"

src/test/resources/test-data/insights-response.json

@@ -129,6 +129,7 @@
     },
     "brand": "Visa",
     "country": "US",
+    "is_business": true,
     "is_issued_in_billing_address_country": true,
     "is_prepaid": true,
     "is_virtual": true,