Minor code cleanup

Author: oschwald

src/main/java/com/maxmind/minfraud/request/AbstractLocation.java

@@ -8,17 +8,17 @@
  * Billing and Shipping.
  */
 public abstract class AbstractLocation extends AbstractModel {
-    protected String firstName;
-    protected String lastName;
-    protected String company;
-    protected String address;
-    protected String address2;
-    protected String city;
-    protected String region;
-    protected String country;
-    protected String postal;
-    protected String phoneNumber;
-    protected String phoneCountryCode;
+    private final String firstName;
+    private final String lastName;
+    private final String company;
+    private final String address;
+    private final String address2;
+    private final String city;
+    private final String region;
+    private final String country;
+    private final String postal;
+    private final String phoneNumber;
+    private final String phoneCountryCode;
 
     protected AbstractLocation(AbstractLocation.Builder builder) {
         firstName = builder.firstName;

src/main/java/com/maxmind/minfraud/request/Event.java

@@ -3,7 +3,6 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.maxmind.minfraud.AbstractModel;
 
-import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.Date;
 
@@ -30,7 +29,6 @@ public static final class Builder {
         String shopId;
         Date time;
         Type type;
-        SimpleDateFormat dateFormat;
 
         /**
          * @param id Your internal ID for the transaction. We can use this to

src/main/java/com/maxmind/minfraud/request/Transaction.java

@@ -48,7 +48,7 @@ public static class Builder {
         Order order;
         Payment payment;
         Shipping shipping;
-        List<ShoppingCartItem> shoppingCart = new ArrayList<>();
+        final List<ShoppingCartItem> shoppingCart = new ArrayList<>();
 
         /**
          * The constructor for {@code Builder}

src/test/java/com/maxmind/minfraud/WebServiceClientTest.java

@@ -23,10 +23,10 @@
 public class WebServiceClientTest {
 
     @Rule
-    public ExpectedException thrown = ExpectedException.none();
+    public final ExpectedException thrown = ExpectedException.none();
 
     @Rule
-    public WireMockRule wireMockRule = new WireMockRule(0); // 0 picks random port
+    public final WireMockRule wireMockRule = new WireMockRule(0); // 0 picks random port
 
     @Test
     public void testFullScoreTransaction() throws Exception {

src/test/java/com/maxmind/minfraud/response/DeviceTest.java

@@ -23,7 +23,7 @@ public void testDevice() throws Exception {
                         .finish()
         );
 
-        assertEquals(99.0, device.getConfidence().doubleValue(), 1e-15);
+        assertEquals(99.0, device.getConfidence(), 1e-15);
         assertEquals(UUID.fromString("C8D3BE1A-BE26-11E5-8C50-1B575C37265F"), device.getId());
         assertEquals("2016-06-08T14:16:38Z", device.getLastSeen());
     }

src/test/java/com/maxmind/minfraud/response/SubscoresTest.java

@@ -9,8 +9,6 @@ public class SubscoresTest extends AbstractOutputTest {
 
     @Test
     public void testSubscores() throws Exception {
-        String phone = "132-342-2131";
-
         Subscores subscores = this.deserialize(
                 Subscores.class,
                 JSON.std