Tidy all code

Author: oschwald

pom.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <groupId>com.maxmind.minfraud</groupId>
@@ -211,7 +212,7 @@
                 <configuration>
                     <format>xml</format>
                     <maxmem>256m</maxmem>
-                    <check />
+                    <check/>
                 </configuration>
             </plugin>
             <plugin>

src/main/java/com/maxmind/minfraud/WebServiceClient.java

@@ -109,7 +109,7 @@ public static final class Builder {
         private ProxySelector proxy = ProxySelector.getDefault();
 
         /**
-         * @param accountId     Your MaxMind account ID.
+         * @param accountId  Your MaxMind account ID.
          * @param licenseKey Your MaxMind license key.
          */
         public Builder(int accountId, String licenseKey) {

src/main/java/com/maxmind/minfraud/request/CreditCard.java

@@ -250,12 +250,12 @@ public String getToken() {
 
     /**
      * @return An indication of whether or not the outcome of 3D-Secure
-     *         verification (e.g. Safekey, SecureCode, Verified by Visa) was
-     *         successful, as provided by the end user. {@code true} if customer
-     *         verification was successful, or {@code false} if the customer
-     *         failed verification. {@code null} if 3-D Secure verification was
-     *         not used, was unavailable, or resulted in another outcome other
-     *         than success or failure.
+     * verification (e.g. Safekey, SecureCode, Verified by Visa) was
+     * successful, as provided by the end user. {@code true} if customer
+     * verification was successful, or {@code false} if the customer
+     * failed verification. {@code null} if 3-D Secure verification was
+     * not used, was unavailable, or resulted in another outcome other
+     * than success or failure.
      */
     @JsonProperty("was_3d_secure_successful")
     public Boolean getWas3dSecureSuccessful() {

src/main/java/com/maxmind/minfraud/request/Email.java

@@ -6,6 +6,7 @@
 import org.apache.commons.codec.digest.DigestUtils;
 import org.apache.commons.validator.routines.DomainValidator;
 import org.apache.commons.validator.routines.EmailValidator;
+
 import java.net.IDN;
 import java.util.Collections;
 import java.util.HashMap;
@@ -55,7 +56,7 @@ public static final class Builder {
 
         /**
          * The constructor for the builder.
-         *
+         * <p>
          * By default, validation will be enabled.
          */
         public Builder() {
@@ -77,7 +78,7 @@ public Builder(boolean enableValidation) {
          * need to set the domain separately. The domain will be set to
          * the domain of the email address and the address field will be
          * set to the email address passed.
-         *
+         * <p>
          * The email address will be sent in plain text unless you also call
          * {@link #hashAddress()} to instead send it as an MD5 hash.
          *
@@ -103,7 +104,7 @@ public Email.Builder address(String address) {
 
         /**
          * Send the email address as its MD5 hash.
-         *
+         * <p>
          * By default the email address set by {@link #address(String)} will be
          * sent in plain text. Enable sending it as an MD5 hash instead by
          * calling this method.

src/main/java/com/maxmind/minfraud/request/TransactionReport.java

@@ -46,8 +46,8 @@ public static final class Builder {
          *
          * @param ipAddress The IP address associated with the device used
          *                  by the customer in the transaction.
-         * @param tag A string indicating the likelihood that a transaction may be
-         *           fraudulent.
+         * @param tag       A string indicating the likelihood that a transaction may be
+         *                  fraudulent.
          */
         public Builder(InetAddress ipAddress, Tag tag) {
             if (ipAddress == null) {
@@ -63,7 +63,7 @@ public Builder(InetAddress ipAddress, Tag tag) {
 
         /**
          * @param chargebackCode A string which is provided by your payment processor
-         * indicating the reason for the chargeback.
+         *                       indicating the reason for the chargeback.
          * @return The builder object.
          */
         public TransactionReport.Builder chargebackCode(String chargebackCode) {
@@ -73,13 +73,13 @@ public TransactionReport.Builder chargebackCode(String chargebackCode) {
 
         /**
          * @param maxmindId A unique eight character string identifying a minFraud
-         * Standard or Premium request. These IDs are returned in the maxmindID field
-         * of a response for a successful minFraud request. This field is not required,
-         * but you are encouraged to provide it, if possible.
+         *                  Standard or Premium request. These IDs are returned in the maxmindID field
+         *                  of a response for a successful minFraud request. This field is not required,
+         *                  but you are encouraged to provide it, if possible.
          * @return The builder object.
          */
         public TransactionReport.Builder maxmindId(String maxmindId) {
-            if (maxmindId.length() != 8 ) {
+            if (maxmindId.length() != 8) {
                 throw new IllegalArgumentException("maxmindId must be exactly 8 characters in length");
             }
             this.maxmindId = maxmindId;
@@ -88,10 +88,10 @@ public TransactionReport.Builder maxmindId(String maxmindId) {
 
         /**
          * @param minfraudId A UUID that identifies a minFraud Score, minFraud Insights,
-         * or minFraud Factors request. This ID is returned via getId() in the
-         * Score, Insights or Factors response object. This field is not
-         * required, but you are encouraged to provide it if the request was
-         * made to one of these services.
+         *                   or minFraud Factors request. This ID is returned via getId() in the
+         *                   Score, Insights or Factors response object. This field is not
+         *                   required, but you are encouraged to provide it if the request was
+         *                   made to one of these services.
          * @return The builder object.
          */
         public TransactionReport.Builder minfraudId(UUID minfraudId) {

src/main/java/com/maxmind/minfraud/response/CreditCard.java

@@ -17,15 +17,14 @@ public final class CreditCard extends AbstractModel {
     private final String type;
 
     /**
+     * @param brand                           The credit card brand.
+     * @param country                         The country the card was issued in.
+     * @param isIssuedInBillingAddressCountry Whether the issuing country matches billing country.
+     * @param isPrepaid                       Whether the card was prepaid.
+     * @param issuer                          The issuer information.
+     * @param type                            The type.
      * @deprecated This constructor only exists for backward compatibility
      * and will be removed in the next major release.
-     *
-     * @param brand The credit card brand.
-     * @param country The country the card was issued in.
-     * @param isIssuedInBillingAddressCountry Whether the issuing country matches billing country.
-     * @param isPrepaid Whether the card was prepaid.
-     * @param issuer The issuer information.
-     * @param type The type.
      */
     public CreditCard(
             String brand,
@@ -36,20 +35,19 @@ public CreditCard(
             String type
     ) {
         this(brand, country, isIssuedInBillingAddressCountry, isPrepaid, false,
-            issuer, type);
+                issuer, type);
     }
 
     /**
+     * @param brand                           The credit card brand.
+     * @param country                         The country the card was issued in.
+     * @param isIssuedInBillingAddressCountry Whether the issuing country matches billing country.
+     * @param isPrepaid                       Whether the card was prepaid.
+     * @param isVirtual                       Whether it is a virtual card.
+     * @param issuer                          The issuer information.
+     * @param type                            The type.
      * @deprecated This constructor only exists for backward compatibility
      * and will be removed in the next major release.
-     *
-     * @param brand The credit card brand.
-     * @param country The country the card was issued in.
-     * @param isIssuedInBillingAddressCountry Whether the issuing country matches billing country.
-     * @param isPrepaid Whether the card was prepaid.
-     * @param isVirtual Whether it is a virtual card.
-     * @param issuer The issuer information.
-     * @param type The type.
      */
     public CreditCard(
             String brand,
@@ -61,7 +59,7 @@ public CreditCard(
             String type
     ) {
         this(brand, country, false, isIssuedInBillingAddressCountry, isPrepaid,
-            isVirtual, issuer, type);
+                isVirtual, issuer, type);
     }
 
 

src/main/java/com/maxmind/minfraud/response/Device.java

@@ -22,12 +22,11 @@ public final class Device extends AbstractModel {
     private final String localTime;
 
     /**
+     * @param confidence The device confidence.
+     * @param id         The device ID.
+     * @param lastSeen   When the device was last seen.
      * @deprecated This constructor only exists for backward compatibility
      * and will be removed in the next major release.
-     *
-     * @param confidence The device confidence.
-     * @param id The device ID.
-     * @param lastSeen When the device was last seen.
      */
     public Device(
             Double confidence,

src/main/java/com/maxmind/minfraud/response/Email.java

@@ -31,13 +31,12 @@ public Email(
     }
 
     /**
+     * @param isDisposable Whether it is a disposable email.
+     * @param isFree       Whether it is a free email.
+     * @param isHighRisk   Whether it is a high risk email.
+     * @param firstSeen    When the email was first seen.
      * @deprecated This constructor only exists for backward compatibility
      * and will be removed in the next major release.
-     *
-     * @param isDisposable Whether it is a disposable email.
-     * @param isFree Whether it is a free email.
-     * @param isHighRisk Whether it is a high risk email.
-     * @param firstSeen When the email was first seen.
      */
     public Email(
             Boolean isDisposable,
@@ -49,12 +48,11 @@ public Email(
     }
 
     /**
+     * @param isFree     Whether it is a free email.
+     * @param isHighRisk Whether it is a high risk email.
+     * @param firstSeen  When the email was first seen.
      * @deprecated This constructor only exists for backward compatibility
      * and will be removed in the next major release.
-     *
-     * @param isFree Whether it is a free email.
-     * @param isHighRisk Whether it is a high risk email.
-     * @param firstSeen When the email was first seen.
      */
     public Email(
             Boolean isFree,
@@ -65,11 +63,10 @@ public Email(
     }
 
     /**
+     * @param isFree     Whether it is a free email.
+     * @param isHighRisk Whether it is a high risk email.
      * @deprecated This constructor only exists for backward compatibility
      * and will be removed in the next major release.
-     *
-     * @param isFree Whether it is a free email.
-     * @param isHighRisk Whether it is a high risk email.
      */
     public Email(
             Boolean isFree,

src/main/java/com/maxmind/minfraud/response/GeoIp2Country.java

@@ -15,15 +15,14 @@ public final class GeoIp2Country extends Country {
     private final boolean isHighRisk;
 
     /**
-     * @deprecated This constructor only exists for backward compatibility
-     * and will be removed in the next major release.
-     *
-     * @param locales The locales.
+     * @param locales    The locales.
      * @param confidence The confidence.
-     * @param geoNameId The GeoName ID.
+     * @param geoNameId  The GeoName ID.
      * @param isHighRisk Whether it is a high risk country.
-     * @param isoCode The ISO code.
-     * @param names The names.
+     * @param isoCode    The ISO code.
+     * @param names      The names.
+     * @deprecated This constructor only exists for backward compatibility
+     * and will be removed in the next major release.
      */
     public GeoIp2Country(
             List<String> locales,

src/main/java/com/maxmind/minfraud/response/IpAddress.java

@@ -39,20 +39,19 @@ public IpAddress(
     }
 
     /**
+     * @param city               The city information.
+     * @param continent          The continent information.
+     * @param country            The country information.
+     * @param location           The location information.
+     * @param maxmind            MaxMind-specific information.
+     * @param postal             The postal information.
+     * @param registeredCountry  The information about the country where the IP was registered.
+     * @param representedCountry The represented country, e.g., for military bases in other countries.
+     * @param risk               The IP risk.
+     * @param subdivisions       The list of subdivisions.
+     * @param traits             Information about various other IP traits.
      * @deprecated This constructor only exists for backward compatibility
      * and will be removed in the next major release.
-     *
-     * @param city The city information.
-     * @param continent The continent information.
-     * @param country The country information.
-     * @param location The location information.
-     * @param maxmind MaxMind-specific information.
-     * @param postal The postal information.
-     * @param registeredCountry The information about the country where the IP was registered.
-     * @param representedCountry The represented country, e.g., for military bases in other countries.
-     * @param risk The IP risk.
-     * @param subdivisions The list of subdivisions.
-     * @param traits Information about various other IP traits.
      */
     public IpAddress(
             City city,