Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ String json = response.toJson(); // Pretty-printed JSON output

The project depends on:
- **Jackson** (core, databind, annotations, datatype-jsr310): JSON handling
- **GeoIP2 Java API**: Sibling library providing GeoIP2 models used in responses
- **GeoIP Java API**: Sibling library providing GeoIP models used in responses
- **JUnit 5** (Jupiter): Testing framework

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Claude, seems right:

  - Missed — CLAUDE.md:71: "Response models include GeoIP2 data" was not updated, while line 430 in the same file was.

- **WireMock**: HTTP mocking for tests
- **jsonassert**: JSON comparison in tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import java.time.ZonedDateTime;

/**
* This class contains minFraud response data related to the GeoIP2 Insights location.
* This class contains minFraud response data related to the GeoIP Insights location.
*
* @param accuracyRadius The approximate accuracy radius in kilometers around the latitude and
* longitude for the geographical entity (country, subdivision, city or
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/maxmind/minfraud/WebServiceClientTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void testFullInsightsTransaction() throws Exception {
var response = client.insights(request);

// We use non-strict checking as there is some extra stuff in the serialized
// object, most notably the "name" field in the GeoIP2 InsightsResponse subobjects.
// object, most notably the "name" field in the GeoIP InsightsResponse subobjects.
// We cannot change this as it would be a breaking change to the GeoIP2 API.
JSONAssert.assertEquals(responseContent, response.toJson(), false);
verifyRequestFor(wireMock, "insights", "full-request");
Expand Down Expand Up @@ -153,7 +153,7 @@ public void testFullFactorsTransaction() throws Exception {
var response = client.factors(request);

// We use non-strict checking as there is some extra stuff in the serialized
// object, most notably the "name" field in the GeoIP2 InsightsResponse subobjects.
// object, most notably the "name" field in the GeoIP InsightsResponse subobjects.
// We cannot change this as it would be a breaking change to the GeoIP2 API.
JSONAssert.assertEquals(responseContent, response.toJson(), false);
verifyRequestFor(wireMock, "factors", "full-request");
Expand Down
Loading