Skip to content

Add anonymizer property to IpAddress model#245

Merged
horgh merged 3 commits into
mainfrom
greg/eng-3902-expose-anonymizer-data-on-minfraud-php-insights-model
Jan 20, 2026
Merged

Add anonymizer property to IpAddress model#245
horgh merged 3 commits into
mainfrom
greg/eng-3902-expose-anonymizer-data-on-minfraud-php-insights-model

Conversation

@oschwald

Copy link
Copy Markdown
Member

Expose the GeoIP2 Insights anonymizer data in the minFraud IpAddress
model. This was previously available in the underlying GeoIP2 library
(since 3.3.0) but not exposed in minFraud responses.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @oschwald, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates and exposes previously unavailable anonymizer data from GeoIP2 Insights within the minFraud IpAddress model. This enhancement provides more detailed information about the anonymity status of IP addresses, improving the comprehensiveness of minFraud responses for users.

Highlights

  • Anonymizer Property Addition: The anonymizer property has been added to the MaxMind\MinFraud\Model\IpAddress class.
  • Data Exposure: This new property exposes GeoIP2 Insights anonymizer data, including VPN detection confidence, provider name, and network last seen date, which was previously available in the GeoIP2 library but not in minFraud responses.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly exposes the anonymizer data from the underlying GeoIP2 library in the minFraud IpAddress model. The changes are well-implemented, including updates to the model, serialization logic, and test data. I've added one suggestion to improve the test coverage for the new anonymizer object to ensure all its properties are correctly mapped and validated.

Comment thread tests/MaxMind/Test/MinFraud/Model/InsightsTest.php
@oschwald
oschwald force-pushed the greg/eng-3902-expose-anonymizer-data-on-minfraud-php-insights-model branch from 364a562 to 99d0b51 Compare January 20, 2026 17:08
Expose the GeoIP2 Insights anonymizer data in the minFraud IpAddress
model. This was previously available in the underlying GeoIP2 library
(since 3.3.0) but not exposed in minFraud responses.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@oschwald
oschwald force-pushed the greg/eng-3902-expose-anonymizer-data-on-minfraud-php-insights-model branch from 99d0b51 to f621b07 Compare January 20, 2026 17:18
horgh
horgh previously approved these changes Jan 20, 2026
@horgh
horgh merged commit d4bb833 into main Jan 20, 2026
52 checks passed
@horgh
horgh deleted the greg/eng-3902-expose-anonymizer-data-on-minfraud-php-insights-model branch January 20, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants