Commit 90ba45d
committed
Fix release process for GitHub immutable releases
The 0.2.0 release failed because two systems were both authoritative for
publishing: dev-bin/release.sh called `gh release create` locally
immediately after pushing the tag, and the tag push also triggered the
release.yml workflow which runs GoReleaser. The local create won the
race and produced a published, asset-less release that became
immediately immutable under GitHub's new immutable releases feature.
GoReleaser then failed to PATCH target_commitish on the existing
release.
Two changes:
- dev-bin/release.sh: drop the trailing `gh release create` call. The
script's job ends at `git push --tags`; CI owns publishing.
- .goreleaser.yml: drop `target_commitish: "{{ .FullCommit }}"` (the
tag already points at the right commit, so the field is unnecessary
and triggers an immutability-incompatible PATCH). Add
`name_template: "{{.Version}}"` so GoReleaser-published releases keep
the same "0.2.0"-style title the manual `gh release create` was
producing.1 parent f73e14f commit 90ba45d
3 files changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
9 | 18 | | |
10 | 19 | | |
11 | 20 | | |
| |||
66 | 75 | | |
67 | 76 | | |
68 | 77 | | |
| 78 | + | |
69 | 79 | | |
70 | 80 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | | - | |
0 commit comments