Skip to content

Commit 90ba45d

Browse files
committed
Fix release process for GitHub immutable releases
The 0.2.0 release failed because two systems were both authoritative for publishing: dev-bin/release.sh called `gh release create` locally immediately after pushing the tag, and the tag push also triggered the release.yml workflow which runs GoReleaser. The local create won the race and produced a published, asset-less release that became immediately immutable under GitHub's new immutable releases feature. GoReleaser then failed to PATCH target_commitish on the existing release. Two changes: - dev-bin/release.sh: drop the trailing `gh release create` call. The script's job ends at `git push --tags`; CI owns publishing. - .goreleaser.yml: drop `target_commitish: "{{ .FullCommit }}"` (the tag already points at the right commit, so the field is unnecessary and triggers an immutability-incompatible PATCH). Add `name_template: "{{.Version}}"` so GoReleaser-published releases keep the same "0.2.0"-style title the manual `gh release create` was producing.
1 parent f73e14f commit 90ba45d

3 files changed

Lines changed: 11 additions & 3 deletions

File tree

.goreleaser.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,4 @@ nfpms:
7575
dst: '/usr/share/doc/mmdbconvert/parquet-queries.md'
7676

7777
release:
78-
target_commitish: "{{ .FullCommit }}"
78+
name_template: "{{.Version}}"

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to
77
[Semantic Versioning](https://semver.org/spec/v2.0.0.html).
88

9+
## [0.2.1] - 2026-05-01
10+
11+
### Fixed
12+
13+
- Release process now works with GitHub's immutable releases feature. The v0.2.0
14+
tag was published but no binaries were attached; v0.2.1 is the first
15+
downloadable 0.2.x release. See the [0.2.0] entry below for the changes
16+
shipped in this version.
17+
918
## [0.2.0] - 2026-05-01
1019

1120
### Added
@@ -66,5 +75,6 @@ and this project adheres to
6675
- Multi-database merge validation
6776
- Performance testing (< 10ms for small databases, 7MB memory)
6877

78+
[0.2.1]: https://github.com/maxmind/mmdbconvert/compare/v0.2.0...v0.2.1
6979
[0.2.0]: https://github.com/maxmind/mmdbconvert/compare/v0.1.0...v0.2.0
7080
[0.1.0]: https://github.com/maxmind/mmdbconvert/releases/tag/v0.1.0

dev-bin/release.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,5 +98,3 @@ $notes"
9898
git tag -a -m "$message" "$tag"
9999

100100
git push --tags
101-
102-
gh release create --target "$current_branch" -t "$version" -n "$notes" "$tag"

0 commit comments

Comments
 (0)