Skip to content

Commit f7311ca

Browse files
committed
code polish
1 parent 17fe719 commit f7311ca

3 files changed

Lines changed: 31 additions & 23 deletions

File tree

.github/workflows/build-cv.yml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,6 @@ on:
1111
- src/data/CV-MGarcia.tex
1212
- src/data/biblio.bib
1313

14-
# Allow this job to clone the repo and create a cv build
15-
permissions:
16-
contents: read
17-
pages: write
18-
id-token: write
19-
2014
# Allow one concurrent build
2115
concurrency:
2216
group: "cv"
@@ -25,13 +19,15 @@ concurrency:
2519
jobs:
2620
build:
2721
runs-on: ubuntu-latest
22+
permissions:
23+
contents: read
2824

2925
steps:
3026
- name: Checkout repository
31-
uses: actions/checkout@v6
27+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
3228

3329
- name: Set up Java
34-
uses: actions/setup-java@v4
30+
uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 # v4
3531
with:
3632
distribution: temurin
3733
java-version: "17"
@@ -49,6 +45,8 @@ jobs:
4945
deploy:
5046
needs: build
5147
runs-on: ubuntu-latest
48+
permissions:
49+
contents: write
5250

5351
steps:
5452
- name: Deploy to cv branch
@@ -58,5 +56,9 @@ jobs:
5856
git config --local user.name "GitHub Action"
5957
git checkout -B cv
6058
git add -f CV-MGarcia-latest.pdf
59+
if git diff --staged --quiet; then
60+
echo "No CV changes to commit"
61+
exit 0
62+
fi
6163
git commit -m "Update CV - $(date +%Y-%m-%d)"
6264
git push -f origin cv

.github/workflows/ci.yml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,22 @@ on:
77
branches: [main]
88
workflow_dispatch:
99

10+
permissions:
11+
contents: read
12+
13+
concurrency:
14+
group: ci-${{ github.workflow }}-${{ github.ref }}
15+
cancel-in-progress: true
16+
1017
jobs:
1118
lint:
1219
runs-on: ubuntu-latest
1320
steps:
1421
- name: Checkout repository
15-
uses: actions/checkout@v6
22+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
1623

1724
- name: Setup Node.js
18-
uses: actions/setup-node@v6
25+
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
1926
with:
2027
node-version: '24'
2128
cache: 'npm'
@@ -33,10 +40,10 @@ jobs:
3340
runs-on: ubuntu-latest
3441
steps:
3542
- name: Checkout repository
36-
uses: actions/checkout@v6
43+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
3744

3845
- name: Setup Node.js
39-
uses: actions/setup-node@v6
46+
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
4047
with:
4148
node-version: '24'
4249
cache: 'npm'

.github/workflows/deploy.yml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Deploy to GitHub Pages
1+
name: Deploy
22

33
on:
44
# Allows you to run this workflow manually from the Actions tab on GitHub.
@@ -18,12 +18,6 @@ on:
1818
- "!src/data/CV-MGarcia.tex"
1919
- "!src/data/biblio.bib"
2020

21-
# Allow this job to clone the repo and create a page deployment
22-
permissions:
23-
contents: read
24-
pages: write
25-
id-token: write
26-
2721
# Allow one concurrent deployment
2822
concurrency:
2923
group: "pages"
@@ -32,25 +26,30 @@ concurrency:
3226
jobs:
3327
build:
3428
runs-on: ubuntu-latest
29+
permissions:
30+
contents: read
3531

3632
steps:
3733
- name: Checkout your repository using git
38-
uses: actions/checkout@v6
34+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
3935

4036
- name: Install, build, and upload your site
41-
uses: withastro/action@v6
37+
uses: withastro/action@44706356b4eb735f8b9035699eb4796241a040c4 # v6
4238
with:
4339
node-version: 24
44-
package-manager: npm@latest
40+
package-manager: npm
4541

4642
deploy:
4743
needs: build
4844
runs-on: ubuntu-latest
45+
permissions:
46+
pages: write
47+
id-token: write
4948
environment:
5049
name: github-pages
5150
url: ${{ steps.deployment.outputs.page_url }}
5251

5352
steps:
5453
- name: Deploy to GitHub Pages
5554
id: deployment
56-
uses: actions/deploy-pages@v5
55+
uses: actions/deploy-pages@cd2ce8fcbc39b97be8ca5fce6e763baed58fa128 # v5

0 commit comments

Comments
 (0)