Commit b05588b
authored
fix(security): clear gitleaks aws-account-id findings (aws-samples#313) (aws-samples#322)
The custom aws-account-id rule (f57b931) flagged 25 findings on main,
failing security:secrets repo-wide. Classified: 21 false positives,
1 real account ID in 3 locations.
- Scrub the one real ID from the live diagram
docs/diagrams/phase3-cedar-hitl.drawio, replacing it with the
AWS-published placeholder 123456789012.
- Allowlist the false positives in .gitleaks.toml, scoped by path:
- .github/workflows/*.yml: 12-digit runs inside Action commit-SHA pins.
- .threat-composer/*.json: v4 UUID final nodes that are all-digit.
- cdk/test/*.test.ts: the RFC-4122 example UUID ...-446655440000.
- Add .gitleaksignore baseline for the same real ID in history
(commit 0dca217: two now-deleted backlog docs + the pre-scrub diagram),
which cannot be removed without rewriting shared main history.
mise run security:secrets now reports 0 leaks. New occurrences are
still flagged; only these specific historical fingerprints are suppressed.
Closes aws-samples#3131 parent af33bc0 commit b05588b
3 files changed
Lines changed: 26 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
0 commit comments