Fix task_deindex_instance crash when object deleted before task runs#45
Open
pranithreddym wants to merge 1 commit into
Open
Fix task_deindex_instance crash when object deleted before task runs#45pranithreddym wants to merge 1 commit into
pranithreddym wants to merge 1 commit into
Conversation
When a document is deleted (e.g. emptied from Trash), Celery may not execute task_deindex_instance until after the DELETE has committed. The task called Model.objects.get(pk=object_id) without guarding for DoesNotExist, causing an unhandled exception and a CRITICAL traceback in the worker logs on every trash-empty operation. task_index_instance already handles this case with a retry; for de-indexing a non-existent object, a retry makes no sense since there is nothing to de-index. The fix catches DoesNotExist, logs a WARNING, and returns cleanly. Also adds a regression test: test_task_deindex_instance_object_already_deleted Fixes GitLab issue #1185.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a document is deleted (e.g. emptied from Trash), Celery may not execute task_deindex_instance until after the DELETE has committed. The task called Model.objects.get(pk=object_id) without guarding for DoesNotExist, causing an unhandled exception and a CRITICAL traceback in the worker logs on every trash-empty operation.
task_index_instance already handles this case with a retry; for de-indexing a non-existent object, a retry makes no sense since there is nothing to de-index. The fix catches DoesNotExist, logs a WARNING, and returns cleanly.
Also adds a regression test:
test_task_deindex_instance_object_already_deleted
Fixes GitLab issue #1185.