Skip to content

fix(demo): alias react/react-dom for Vite 8 / Rolldown compatibility#60

Merged
mayank-patel merged 1 commit into
mainfrom
fix/deploy-demo-vite8-react-resolve
Apr 8, 2026
Merged

fix(demo): alias react/react-dom for Vite 8 / Rolldown compatibility#60
mayank-patel merged 1 commit into
mainfrom
fix/deploy-demo-vite8-react-resolve

Conversation

@mayank-patel
Copy link
Copy Markdown
Owner

Summary

  • Vite 8 switched from Rollup to Rolldown as its bundler
  • Rolldown cannot resolve react/react-dom peer deps when processing files outside the demo project root (../../src/index.tsx)
  • Adds explicit resolve.alias entries pointing both modules to demo/node_modules/react and demo/node_modules/react-dom

Test plan

  • CI passes on this PR
  • Deploy Demo workflow succeeds after merge

…mpat

Vite 8 uses Rolldown which fails to resolve peer deps (react, react-dom)
when importing from files outside the project root (../../src/index.tsx).
Explicit aliases force resolution to the demo's local node_modules.
@mayank-patel mayank-patel merged commit c557e71 into main Apr 8, 2026
1 check passed
@mayank-patel mayank-patel deleted the fix/deploy-demo-vite8-react-resolve branch April 8, 2026 06:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant