Skip to content

Commit 0587e7f

Browse files
authored
fix(themes): update github theme accent color to high-contrast #39d353 (JhaSourav07#1674)
## Description Fixes JhaSourav07#1670 The `github` theme in `lib/svg/themes.ts` used `#238636` as its accent color, which has a contrast ratio of only ~2.2:1 against the dark background (`#0d1117`). This made label text, streak stats, and glowing particles extremely muddy and difficult to read. **Changes made:** - Updated the `github` theme accent color in `lib/svg/themes.ts` from `#238636` to `#39d353` (GitHub's bright green used for contribution cells), achieving a contrast ratio of ~5.5:1 - Updated `THEMES.md` to reflect the new accent color - Updated `README.md` theme table to reflect the new accent color ## Pillar - [x] 🎨 Pillar 1 — New Theme Design - [ ] 📐 Pillar 2 — Geometric SVG Improvement - [ ] 🕐 Pillar 3 — Timezone Logic Optimization - [ ] 🛠️ Other (Bug fix, refactoring, docs) ## Checklist before requesting a review: - [x] I have read the `CONTRIBUTING.md` file. - [x] I have tested these changes locally (`localhost:3000/api/streak?user=Pranav-IIITM&theme=github`). - [x] I have run `npm run format` and `npm run lint` locally and resolved all errors (CI will fail otherwise). - [x] My commits follow the Conventional Commits format (e.g., `feat(themes): ...`, `fix(calculate): ...`). - [x] I have updated `README.md` if I added a new theme or URL parameter. - [x] I have started the repo. - [x] I have made sure that i have only one commit to merge in this PR. - [x] The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts). - [x] (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.
2 parents d15eb6b + 5960c8d commit 0587e7f

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ URL Parameter > Theme Default > System Fallback
212212
| `dark` _(default)_ | GitHub dark | `0d1117` | `58a6ff` | `c9d1d9` |
213213
| `neon` | Cyberpunk | `000000` | `ff00ff` | `00ffcc` |
214214
| `dracula` | Dracula Pro | `282a36` | `bd93f9` | `f8f8f2` |
215-
| `github` | GitHub green | `0d1117` | `238636` | `ffffff` |
215+
| `github` | GitHub green | `0d1117` | `39d353` | `ffffff` |
216216
| `light` | Clean & minimal | `ffffff` | `0969da` | `24292f` |
217217
| `gruvbox` | retro warm dark | `282828` | `fe8019` | `ebdbb2` |
218218
| `random` | Surprise theme on reload | _varies_ | _varies_ | _varies_ |

THEMES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ https://commitpulse.vercel.app/api/badge?username=YOUR_USERNAME&theme=<slug>
1616
| dark | `#0d1117` | `#c9d1d9` | `#58a6ff` |
1717
| light | `#ffffff` | `#24292f` | `#0969da` |
1818
| neon | `#000000` | `#00ffcc` | `#ff00ff` |
19-
| github | `#0d1117` | `#ffffff` | `#238636` |
19+
| github | `#0d1117` | `#ffffff` | `#39d353` |
2020
| dracula | `#282a36` | `#f8f8f2` | `#bd93f9` |
2121
| ocean | `#0a192f` | `#ccd6f6` | `#64ffda` |
2222
| sunset | `#1a0a0a` | `#ffd6c0` | `#ff6b35` |

lib/svg/themes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const themes: Record<string, BadgeTheme> = {
1414
dark: makeTheme('0d1117', 'c9d1d9', '58a6ff'),
1515
light: makeTheme('ffffff', '24292f', '0969da'),
1616
neon: makeTheme('000000', '00ffcc', 'ff00ff'),
17-
github: makeTheme('0d1117', 'ffffff', '238636'),
17+
github: makeTheme('0d1117', 'ffffff', '39d353'),
1818
dracula: makeTheme('282a36', 'f8f8f2', 'bd93f9'),
1919
ocean: makeTheme('0a192f', 'ccd6f6', '64ffda'),
2020
sunset: makeTheme('1a0a0a', 'ffd6c0', 'ff6b35'),

0 commit comments

Comments
 (0)