test: handle state 3 transaction rollbacks and clean up dbConnect tests

Author: TanmayNelge

lib/mongodb.test.ts

@@ -105,7 +105,6 @@ describe('dbConnect', () => {
     process.env.MONGODB_URI = 'mongodb://localhost:27017/test';
     global.mongoose.conn = null;
 
-    //const mockMongoose = { connection: 'mock' };
     vi.mocked(mongoose.connect).mockRejectedValue(new Error('Database is disconnected'));
 
     await expect(dbConnect()).rejects.toThrow('Database is disconnected');
@@ -114,21 +113,6 @@ describe('dbConnect', () => {
     expect(global.mongoose.promise).toBeNull();
   });
 
-  it('handles mongoose Connection State 3 (disconnecting) gracefully', async () => {
-    process.env.MONGODB_URI = 'mongodb://localhost:27017/test';
-    global.mongoose.conn = null;
-    mockMongooseConnection.readyState = 3;
-
-    const mockMongoose = { connection: 'mock' };
-    setConnectedMongoose(mockMongoose as unknown as typeof mongoose);
-
-    const conn = await dbConnect();
-
-    expect(mongoose.connect).toHaveBeenCalledTimes(1);
-    expect(conn).toBe(mockMongoose);
-    expect(global.mongoose.conn).toBe(mockMongoose);
-  });
-
   it('returns the cached connection immediately when mongoose is already connected', async () => {
     process.env.MONGODB_URI = 'mongodb://localhost:27017/test';
 
@@ -169,13 +153,17 @@ describe('dbConnect', () => {
 
   it('handles mongoose Connection State 3 (disconnecting) gracefully', async () => {
     process.env.MONGODB_URI = 'mongodb://localhost:27017/test';
+    global.mongoose.conn = null;
     mockMongooseConnection.readyState = 3;
-    const mockMDB = { connection: 'mock' };
-    setConnectedMongoose(mockMDB as unknown as typeof mongoose);
 
-    const res = await dbConnect();
+    const mockMongoose = { connection: 'mock' };
+    setConnectedMongoose(mockMongoose as unknown as typeof mongoose);
+
+    const conn = await dbConnect();
+
     expect(mongoose.connect).toHaveBeenCalledTimes(1);
-    expect(res).toBe(mockMDB);
+    expect(conn).toBe(mockMongoose);
+    expect(global.mongoose.conn).toBe(mockMongoose);
   });
 
   it('reuses an in-flight promise when state 3 triggers concurrent dbConnect calls', async () => {

models/User.test.ts

@@ -406,4 +406,51 @@ describe('User Schema Behaviors under Connection State 2 (Variation 3)', () => {
 
     readyStateSpy.mockRestore();
   });
+
+  describe('Database Connection State 3 (Disconnecting) Handling', () => {
+    it('aborts/rolls back active transactions cleanly when connection is in state 3 (disconnecting)', async () => {
+      const { vi } = await import('vitest');
+
+      const readyStateSpy = vi
+        .spyOn(mongoose.connection, 'readyState', 'get')
+        .mockReturnValue(3 as unknown as typeof mongoose.connection.readyState);
+
+      const mockSession = {
+        startTransaction: vi.fn(),
+        commitTransaction: vi.fn(),
+        abortTransaction: vi.fn().mockResolvedValue(undefined),
+        endSession: vi.fn().mockResolvedValue(undefined),
+      } as unknown as mongoose.ClientSession;
+
+      const startSessionSpy = vi.spyOn(mongoose, 'startSession').mockResolvedValue(mockSession);
+
+      const runTransactionWithCheck = async (session: mongoose.ClientSession) => {
+        session.startTransaction();
+        try {
+          if (mongoose.connection.readyState === 3) {
+            await session.abortTransaction();
+            return { status: 'aborted' };
+          }
+          await session.commitTransaction();
+          return { status: 'committed' };
+        } catch (error) {
+          await session.abortTransaction();
+          throw error;
+        } finally {
+          await session.endSession();
+        }
+      };
+
+      const session = await mongoose.startSession();
+      const result = await runTransactionWithCheck(session);
+
+      expect(result.status).toBe('aborted');
+      expect(mockSession.abortTransaction).toHaveBeenCalledTimes(1);
+      expect(mockSession.endSession).toHaveBeenCalledTimes(1);
+      expect(mockSession.commitTransaction).not.toHaveBeenCalled();
+
+      readyStateSpy.mockRestore();
+      startSessionSpy.mockRestore();
+    });
+  });
 });