fix(validation): enforce year >= 2008 with consistent error message in Zod schema

Author: Subhooo5

app/api/streak/route.test.ts

@@ -260,23 +260,23 @@ describe('GET /api/streak', () => {
       const body = await response.json();
 
       expect(response.status).toBe(400);
-      expect(body.details.fieldErrors.year[0]).toContain('Invalid "year" parameter');
+      expect(body.details.fieldErrors.year[0]).toContain('GitHub was founded in 2008');
     });
 
     it('returns 400 for malformed numeric year', async () => {
       const response = await GET(makeRequest({ user: 'octocat', year: '100000' }));
       const body = await response.json();
 
       expect(response.status).toBe(400);
-      expect(body.details.fieldErrors.year[0]).toContain('Invalid "year" parameter');
+      expect(body.details.fieldErrors.year[0]).toContain('GitHub was founded in 2008');
     });
 
     it('returns 400 for years before GitHub existed', async () => {
       const response = await GET(makeRequest({ user: 'octocat', year: '1999' }));
       const body = await response.json();
 
       expect(response.status).toBe(400);
-      expect(body.details.fieldErrors.year[0]).toContain('Invalid "year" parameter');
+      expect(body.details.fieldErrors.year[0]).toContain('GitHub was founded in 2008');
     });
 
     it('returns 400 for future years', async () => {
@@ -286,7 +286,7 @@ describe('GET /api/streak', () => {
       const body = await response.json();
 
       expect(response.status).toBe(400);
-      expect(body.details.fieldErrors.year[0]).toContain('Invalid "year" parameter');
+      expect(body.details.fieldErrors.year[0]).toContain('GitHub was founded in 2008');
     });
   });
 

lib/validations.ts

@@ -34,21 +34,18 @@ export const streakParamsSchema = z.object({
   font: z.string().optional(),
   year: z
     .string()
-    .regex(/^\d{4}$/, {
-      message: 'Invalid "year" parameter. Use YYYY format, e.g. 2024.',
-    })
+    .optional()
     .refine(
-      (year) => {
-        const yearNum = parseInt(year, 10);
+      (val) => {
+        if (!val) return true;
+        const yearNum = parseInt(val, 10);
         const currentYear = new Date().getFullYear();
-
-        return yearNum >= 2005 && yearNum <= currentYear;
+        return /^\d{4}$/.test(val) && yearNum >= 2008 && yearNum <= currentYear;
       },
       {
-        message: 'Invalid "year" parameter. Use YYYY format, e.g. 2024.',
+        message: 'GitHub was founded in 2008. Please provide a year of 2008 or later.',
       }
-    )
-    .optional(),
+    ),
   refresh: z
     .string()
     .optional()