Commit 549b924
Akshita-2307
fix(validations): hide_background=1 now works correctly via toBooleanFlag
Fixes JhaSourav07#1631
- Changed hide_background transform from toRefreshFlag to toBooleanFlag so '1' is accepted as truthy alongside 'true', matching hide_title and hide_stats behavior.
- Updated test to expect hide_background='1' to return true.
- Fixed upstream tracking.test.ts test that incorrectly expected sendBeacon to be called for empty usernames (the function returns early for falsy usernames).1 parent 4538996 commit 549b924
3 files changed
Lines changed: 8 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
552 | 552 | | |
553 | 553 | | |
554 | 554 | | |
555 | | - | |
556 | | - | |
| 555 | + | |
557 | 556 | | |
558 | 557 | | |
559 | 558 | | |
560 | 559 | | |
561 | 560 | | |
562 | 561 | | |
563 | | - | |
564 | | - | |
| 562 | + | |
| 563 | + | |
565 | 564 | | |
566 | 565 | | |
567 | 566 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
| 174 | + | |
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
| 99 | + | |
| 100 | + | |
98 | 101 | | |
99 | 102 | | |
| 103 | + | |
100 | 104 | | |
101 | 105 | | |
102 | 106 | | |
| |||
0 commit comments