Skip to content

Commit ddb1c07

Browse files
committed
test(github): add bounds check for extreme values in generateAchievements
1 parent 6c969f6 commit ddb1c07

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

lib/github.test.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -538,6 +538,16 @@ describe('generateAchievements', () => {
538538

539539
expect(unlocked.some((a) => a.title === '100 Day Streak')).toBe(false);
540540
});
541+
542+
it('caps progress between 0 and 100 for extreme values', () => {
543+
const achievements = generateAchievements(999999, 999999);
544+
545+
for (const item of achievements) {
546+
expect(Number.isFinite(item.progress)).toBe(true);
547+
expect(item.progress).toBeGreaterThanOrEqual(0);
548+
expect(item.progress).toBeLessThanOrEqual(100);
549+
}
550+
});
541551
});
542552

543553
describe('validateGitHubUsername', () => {

0 commit comments

Comments
 (0)