test(tracking): add coverage for non-serializable JSON payloads

Author: parneetbrar234-svg

utils/tracking.test.ts

@@ -118,20 +118,23 @@ describe('trackUser', () => {
 
     expect(fetchMock).toHaveBeenCalledTimes(1);
   });
-     it('reports format error for non-serializable JSON payload', () => {
-    const consoleErrorMock = vi.spyOn(console, 'error').mockImplementation(() => {});
-    const fetchMock = vi.fn();
-    vi.stubGlobal('fetch', fetchMock);
+    it('reports format error for non-serializable JSON payload', () => {
+  const consoleErrorMock = vi.spyOn(console, 'error').mockImplementation(() => {});
+  const fetchMock = vi.fn();
+  vi.stubGlobal('fetch', fetchMock);
 
-    const payload: Record<string, unknown> = {};
-    payload.self = payload;
+  const payload: Record<string, unknown> = {};
+  payload.self = payload;
 
-    trackUser(payload as unknown as string);
+  trackUser(payload as unknown as string);
 
-    expect(consoleErrorMock).toHaveBeenCalledWith(
-      'Failed to format tracking payload',
-      expect.any(TypeError),
-    );
+  expect(consoleErrorMock).toHaveBeenCalledWith(
+    'Failed to format tracking payload',
+    expect.any(TypeError),
+  );
+
+  expect(fetchMock).not.toHaveBeenCalled();
+});
 
   it('handles non-serializable input gracefully without throwing', () => {
     // A circular reference cannot be serialized by JSON.stringify and will throw
@@ -189,4 +192,4 @@ describe('trackUser', () => {
     expect(sendBeaconMock).not.toHaveBeenCalled();
     expect(fetchMock).not.toHaveBeenCalled();
   });
-});
+});

utils/tracking.ts

@@ -1,19 +1,12 @@
 export function trackUser(username: string) {
-  if (!username || username.trim() === '') {
-    return;
-  }
   if (typeof navigator === 'undefined' || typeof window === 'undefined') return;
   if (!username) return;
-
   let payload: string;
 
   try {
     payload = JSON.stringify({ username });
   } catch (error) {
     console.error('Failed to format tracking payload', error);
-  try {
-    payload = JSON.stringify({ username });
-  } catch {
     return;
   }