Commit f4da6cd
authored
fix(api): guard malformed GraphQL error responses (JhaSourav07#812)
## Description
Fixes JhaSourav07#807
## Pillar
- [x] 🛠️ Other (Bug fix, refactoring, docs)
## What changed
The GitHub GraphQL client assumed every GraphQL error response had a
non-empty `errors` array with a `message` string at index `0`.
That meant responses like:
```json
{ "errors": [] }
```
or:
```json
{ "errors": [{}] }
```
could throw a runtime `TypeError` instead of a controlled API error. I
added a small guard that normalizes malformed GraphQL error payloads to
a stable fallback message while preserving the existing behavior for
normal GitHub errors such as `Bad credentials`.
I also made the response `data` field optional in the local response
type and changed the user lookup to use optional chaining so malformed
responses do not crash while checking `data.user`.
## Visual Preview
N/A — this is API error handling and test coverage only.
## Testing
```bash
npm run format
npm run test -- lib/github.test.ts
npm run lint
npm run typecheck
npm run test
npm run build
```
## Checklist before requesting a review:
- [x] I have read the `CONTRIBUTING.md` file.
- [x] I have tested these changes locally
(`localhost:3000/api/streak?user=YOUR_USERNAME`).
- [x] I have run `npm run format` and `npm run lint` locally and
resolved all errors.
- [x] My commits follow the Conventional Commits format.
- [x] I have updated `README.md` if I added a new theme or URL
parameter.
- [x] I have starred the repo.
- [x] I have made sure that I have only one commit to merge in this PR.
- [x] The SVG output matches the CommitPulse quality standard.2 files changed
Lines changed: 49 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
| 138 | + | |
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
142 | 166 | | |
143 | 167 | | |
144 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
95 | 114 | | |
96 | 115 | | |
97 | 116 | | |
| |||
264 | 283 | | |
265 | 284 | | |
266 | 285 | | |
267 | | - | |
268 | | - | |
| 286 | + | |
| 287 | + | |
269 | 288 | | |
270 | 289 | | |
271 | | - | |
| 290 | + | |
272 | 291 | | |
273 | 292 | | |
274 | 293 | | |
| |||
0 commit comments