Skip to content

Commit a79c140

Browse files
Mayur Piseclaude
authored andcommitted
chore(skills): apply Tessl-review feedback, fix draft conflicts, drop CI workflows
- skills/draft: resolve unresolved merge conflicts, restore /draft:discover, convert file:// URLs to relative paths, condense checkpoints to a table, trim example outputs, add new reference files (context-files, intent-mapping, quality-guide) - skills/discover: include real verify-citations.sh invocation syntax - skills/impact: add sample report output structure - skills/tour: handle wrong/partial challenge answers - skills/documentation: add pre-save link/path validation step - skills/docs: add ambiguous-intent clarification rule - regenerate integrations/copilot output - drop .github/workflows/{ci,skill-review}.yml Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 26ca625 commit a79c140

12 files changed

Lines changed: 338 additions & 242 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.github/workflows/skill-review.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

integrations/copilot/.github/copilot-instructions.md

Lines changed: 34 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10165,7 +10165,7 @@ When user says "discover features" or "draft discover [path]":
1016510165
- Schema: [core/shared/discovery-schema.md](../../core/shared/discovery-schema.md)
1016610166
- Template: [core/templates/discovery.md](../../core/templates/discovery.md)
1016710167
- Hygiene rules: [core/shared/template-hygiene.md](../../core/shared/template-hygiene.md)
10168-
- Citation verifier: `scripts/tools/verify-citations.sh`
10168+
- Citation verifier: `scripts/tools/verify-citations.sh tracks/<track-id>` (exit 0 = clean, 1 = drift detected; add `--tolerance N` to widen the line-window match)
1016910169

1017010170
## Inputs
1017110171

@@ -10348,6 +10348,8 @@ If no explicit mode is specified, infer the intent from the user's prompt:
1034810348
| "Log technical debt", "We need to fix this later", "Track shortcuts" | Tech Debt | `draft tech-debt` |
1034910349
| "How does this work?", "Walk me through the codebase", "Onboard me" | System Tour | `draft tour` |
1035010350

10351+
**Ambiguous phrasing** (e.g., "document our testing approach" could match `documentation` or `testing-strategy`): do not guess. Ask the user one clarifying question — "Do you want (a) prose docs describing the existing tests, or (b) a test plan defining what to test next?" — then route.
10352+
1035110353
## Step 2: Bare Parent Command Fallback
1035210354

1035310355
If the user runs a bare `draft docs` without clear intent, present a small documentation menu with a recommended default path based on the current context:
@@ -12595,6 +12597,11 @@ Save to:
1259512597

1259612598
Create `draft/docs/` directory if needed.
1259712599

12600+
**Pre-save validation:**
12601+
- Every file path referenced in the doc resolves to a real file (broken links are a common LLM failure mode here).
12602+
- Every relative link in the doc resolves under the project root.
12603+
- Code blocks copied from sources match the current commit (no stale snippets).
12604+
1259812605
Present generated doc to user for review before final save.
1259912606

1260012607
## Cross-Skill Dispatch
@@ -14064,6 +14071,9 @@ Provide an interactive codebase walk-through based on existing architecture and
1406414071
2. **Interactive Cadence:** Ask the developer if they are familiar with the tech stack constraints found in `draft/tech-stack.md`.
1406514072
3. **Module Introduction:** Instead of listing all modules, introduce the "Entry Point" module first.
1406614073
4. **Active Challenge:** After explaining a module's responsibility, challenge the developer: "Based on our *Context-Driven Development* rules, how do you think we handle data persistence here?" Wait for their answer before revealing the architecture strategy.
14074+
- If the answer is correct, confirm briefly and cite the supporting line in `architecture.md` / `guardrails.md`.
14075+
- If the answer is partially right, name what they got right, then ask a narrower follow-up (e.g., "Right that we cache reads — what's the invalidation trigger?") before revealing the rest.
14076+
- If the answer is wrong, do not just hand them the answer. Quote the specific guardrail or HLD section that contradicts it, then re-prompt with a hint scoped to that section.
1406714077
5. **Traceability:** Highlight `draft/.state/facts.json` showing how module constraints have evolved.
1406814078
6. **Track Lifecycle Walk:** Show the full feature lifecycle and who owns each gate:
1406914079
- `draft new-track` → `spec.md` (requirements + classification + approvers) + `plan.md` (phases/tasks)
@@ -14121,12 +14131,29 @@ Generate a project-wide impact report measuring Context-Driven Development effec
1412114131
- Count modules decomposed via `draft decompose`.
1412214132

1412314133
5. **Report Output:**
14124-
Generate a Markdown report with sections:
14125-
- **Summary:** Total tracks, completed, in-progress, abandoned.
14126-
- **Delivery Pace:** Average and median track duration.
14127-
- **Friction Hotspots:** Tracks with highest revert counts, longest stalls, or phase regressions.
14128-
- **CDD Adoption:** ADR count, guardrail growth, decomposition usage.
14129-
- **Recommendations:** Actionable suggestions based on detected friction patterns.
14134+
Generate a Markdown report with sections shown below. The shape is fixed so reports diff cleanly across runs.
14135+
14136+
```markdown
14137+
# Draft Impact Report — {YYYY-MM-DD}
14138+
14139+
## Summary
14140+
- Total tracks: 12 (Completed: 7, In-progress: 3, Abandoned: 2)
14141+
14142+
## Delivery Pace
14143+
- Average track duration: 8.4 days | Median: 6 days
14144+
- Phases exceeding 14d without update: <list track IDs or "none">
14145+
14146+
## Friction Hotspots
14147+
| Track | Reverts | Stall (days) | Notes |
14148+
|---|---|---|---|
14149+
| track-042 | 3 | 9 | Reverted after review; spec scope unclear |
14150+
14151+
## CDD Adoption
14152+
- ADRs: 4 | Guardrail entries: 11 | Decomposed modules: 6
14153+
14154+
## Recommendations
14155+
- <one actionable suggestion per detected pattern>
14156+
```
1413014157

1413114158
---
1413214159

skills/discover/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ description: Draft Phase 0 — produce a discovery.md code-spike report before s
1515
- Schema: [core/shared/discovery-schema.md](../../core/shared/discovery-schema.md)
1616
- Template: [core/templates/discovery.md](../../core/templates/discovery.md)
1717
- Hygiene rules: [core/shared/template-hygiene.md](../../core/shared/template-hygiene.md)
18-
- Citation verifier: `scripts/tools/verify-citations.sh`
18+
- Citation verifier: `scripts/tools/verify-citations.sh tracks/<track-id>` (exit 0 = clean, 1 = drift detected; add `--tolerance N` to widen the line-window match)
1919

2020
## Inputs
2121

skills/docs/SKILL.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ If no explicit mode is specified, infer the intent from the user's prompt:
4040
| "Log technical debt", "We need to fix this later", "Track shortcuts" | Tech Debt | `/draft:tech-debt` |
4141
| "How does this work?", "Walk me through the codebase", "Onboard me" | System Tour | `/draft:tour` |
4242

43+
**Ambiguous phrasing** (e.g., "document our testing approach" could match `documentation` or `testing-strategy`): do not guess. Ask the user one clarifying question — "Do you want (a) prose docs describing the existing tests, or (b) a test plan defining what to test next?" — then route.
44+
4345
## Step 2: Bare Parent Command Fallback
4446

4547
If the user runs a bare `/draft:docs` without clear intent, present a small documentation menu with a recommended default path based on the current context:

skills/documentation/SKILL.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,11 @@ Save to:
179179

180180
Create `draft/docs/` directory if needed.
181181

182+
**Pre-save validation:**
183+
- Every file path referenced in the doc resolves to a real file (broken links are a common LLM failure mode here).
184+
- Every relative link in the doc resolves under the project root.
185+
- Code blocks copied from sources match the current commit (no stale snippets).
186+
182187
Present generated doc to user for review before final save.
183188

184189
## Cross-Skill Dispatch

0 commit comments

Comments
 (0)