round one Claude code review

Author: mboot-github

CLAUDE_TODO

@@ -0,0 +1,39 @@
+---
+
+# TLD regex database compiled eagerly at import
+whoisdomain/helpers.py · lines 99–100
+
+Importing whoisdomain forces processing all 3,000+ lines of ZZ immediately. Consumers who only need one TLD pay the cost of all of them. Make MY_TLD_INFO lazy — initialize on first call to get_TLD_RE() or filterTldToSupportedPattern(). Bonus: significantly faster python -c "import whoisdomain", which matters for CLI tools and lambdas.
+
+---
+
+# ParameterContext is a JSON-parsed config rather than a dataclass
+whoisdomain/context/parameterContext.py
+
+A 150-line JSON literal is parsed at import to define ~25 parameters, then __getattr__ returns Any for every read. mypy can't help you, IDE autocomplete can't help your users, and the validation code (~80 lines) duplicates what @dataclass(slots=True) + __post_init__ would give you for free. Sketch:
+
+@dataclass(slots=True)
+class ParameterContext:
+    cmd: str = "whois"
+    timeout: float = 30.0
+    cache_age: int = 60 * 60 * 48
+    verbose: bool = False
+    rdap_only: bool = False
+    # ... etc
+    def to_json(self) -> str: return json.dumps(asdict(self))
+    @classmethod
+    def from_json(cls, s: str) -> "ParameterContext":
+        return cls(**json.loads(s))
+
+---
+
+# Module-level mutable globals everywhere
+helpers.py:99, doWhoisCommand.py:20, lastWhois.py:21, main.py:550
+
+MY_TLD_INFO, CACHE_STUB, LastWhois, and a 14-name global declaration in main(). This makes the package effectively a singleton — concurrent users (e.g. an async webapp) will fight over state, and tests can't run in parallel. Move shared state onto a Whois client class that callers instantiate, and keep the module-level helpers as thin wrappers around a default instance for backwards compatibility.
+
+---
+
+# Quick nits
+is True / is False comparisons throughout — just use if x: / if not x:
+~40 sites

Makefile.tests

@@ -12,8 +12,8 @@ TEST_OPTIONS_ALL = \
 # --------------------------------------------------
 # Tests
 # --------------------------------------------------
-# test: prep test1 test2 test3 test4
-test: prep test2
+test: prep test1 test2 test3 test4
+# test: prep test2
 
 prep:
 	mkdir -p tmp

README.md

@@ -99,8 +99,9 @@ and `make suggest`.
 
 ## in progress
 
+
+## 2.20260522.1
+
 - switch to minimal version 3.10
 - update gitgub-action lint (mypy) to use `setup-python@v6` and `checkout@v6`
 - start working on v2 with rdap first
-
-## 2.20260522.1

analizer/vtmp/bin/normalizer

@@ -1,8 +1,6 @@
 #!/home/mboot/DEV/00-github.com/mboot-github/WhoisDomain/analizer/vtmp/bin/python3.10
-# -*- coding: utf-8 -*-
-import re
 import sys
 from charset_normalizer.cli import cli_detect
 if __name__ == '__main__':
-    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
+    sys.argv[0] = sys.argv[0].removesuffix('.exe')
     sys.exit(cli_detect())

analizer/vtmp/bin/pip

@@ -1,8 +1,6 @@
 #!/home/mboot/DEV/00-github.com/mboot-github/WhoisDomain/analizer/vtmp/bin/python3.10
-# -*- coding: utf-8 -*-
-import re
 import sys
 from pip._internal.cli.main import main
 if __name__ == '__main__':
-    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
+    sys.argv[0] = sys.argv[0].removesuffix('.exe')
     sys.exit(main())

analizer/vtmp/bin/pip3

@@ -1,8 +1,6 @@
 #!/home/mboot/DEV/00-github.com/mboot-github/WhoisDomain/analizer/vtmp/bin/python3.10
-# -*- coding: utf-8 -*-
-import re
 import sys
 from pip._internal.cli.main import main
 if __name__ == '__main__':
-    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
+    sys.argv[0] = sys.argv[0].removesuffix('.exe')
     sys.exit(main())

analizer/vtmp/bin/pip3.10

@@ -1,8 +1,6 @@
 #!/home/mboot/DEV/00-github.com/mboot-github/WhoisDomain/analizer/vtmp/bin/python3.10
-# -*- coding: utf-8 -*-
-import re
 import sys
 from pip._internal.cli.main import main
 if __name__ == '__main__':
-    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
+    sys.argv[0] = sys.argv[0].removesuffix('.exe')
     sys.exit(main())

analizer/vtmp/bin/url-normalize

@@ -1,8 +1,6 @@
 #!/home/mboot/DEV/00-github.com/mboot-github/WhoisDomain/analizer/vtmp/bin/python3.10
-# -*- coding: utf-8 -*-
-import re
 import sys
 from url_normalize.cli import main
 if __name__ == '__main__':
-    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
+    sys.argv[0] = sys.argv[0].removesuffix('.exe')
     sys.exit(main())

whoisdomain/__init__.py

@@ -9,7 +9,6 @@
 All public data is vizible via the __all__ List
 """
 
-import gc
 import logging
 import os
 import sys
@@ -67,9 +66,6 @@
 except ImportError as e:
     _ = e
 
-if HAS_REDIS:
-    from .cache.redisCache import RedisCache
-
 WHOISDOMAIN: str = ""
 if os.getenv("WHOISDOMAIN"):
     WHOISDOMAIN = str(os.getenv("WHOISDOMAIN"))
@@ -88,6 +84,7 @@
 except ImportError as e:
     _ = e  # ignore any error
 
+
 __all__ = [
     "VERSION",
     "ZZ",
@@ -124,6 +121,11 @@
     "validTlds",
 ]
 
+if HAS_REDIS:
+    from .cache.redisCache import RedisCache
+
+    __all__ += ["RedisCache"]
+
 
 def _result2dict(
     func: Any,
@@ -195,13 +197,6 @@ def q2(
     domain: str,
     pc: ParameterContext,
 ) -> Domain | None:
-    if pc.verbose is True:
-        logging.basicConfig(level="DEBUG")
-
-    gc.collect(0)
-    gc.collect(1)
-    gc.collect(2)
-
     dc = DataContext(
         domain=domain,
         hasLibTld=TLD_LIB_PRESENT,
@@ -249,20 +244,7 @@ def q2(
         parser=parser,
     )
 
-    result = pwdr.processRequest()
-
-    del pwdr
-    del dom
-    del wci
-    del parser
-    del dc
-    del pc
-
-    gc.collect(0)
-    gc.collect(1)
-    gc.collect(2)
-
-    return result
+    return pwdr.processRequest()
 
 
 def query(
@@ -298,10 +280,7 @@ def query(
     #    whoisOnly: bool = false,
 ) -> Domain | None:
     assert isinstance(domain, str), Exception("`domain` - must be <str>")
-
-    if verbose is True:
-        logging.basicConfig(level="DEBUG")
-
+    _ = verbose  # ha_ck
     if pc is None:
         pc = ParameterContext(**kwargs)
 
@@ -313,3 +292,21 @@ def query(
 
 # Add get function to support return result in dictionary form
 get = _result2dict(query)
+
+# CLAUDE: logging changes
+# Calling logging.basicConfig(level="DEBUG") inside library code mutates the application's root logger
+# and is widely considered bad library citizenship.
+# If the caller's app uses logging, you've just overridden their config.
+# Use a per-package logger and let the caller configure the level:
+#  logging.getLogger("whoisdomain").setLevel("DEBUG"),
+#  or document a setup_logging(verbose=) helper that callers can opt into.
+
+#  CLAUDE: memoryleak:
+# Three calls — gc.collect(0); gc.collect(1); gc.collect(2) — once on entry and once on exit.
+# gc.collect(2) already does generations 0 and 1, so the other two are redundant.
+# More importantly, manual GC in library code imposes work on callers who don't need it
+# (Python's GC is generational and usually correct without help).
+# The del spam right above isn't doing anything either
+# — locals are about to go out of scope.
+# If you're chasing a real leak, profile it with tracemalloc;
+# otherwise this is cargo-culted overhead.

whoisdomain/context/dataContext.py

@@ -29,6 +29,6 @@ def __init__(
         self.whoisStr: str = ""  # the result string from whois cli after clean
 
         self.data: dict[str, Any] = {}  # the data we need to build the domain object
-        self.exeptionStr: str | None = None  # if we handle exceptions as result string instead of throw
+        self.exceptionStr: str | None = None  # if we handle exceptions as result string instead of throw
         self.thisTld: dict[str, Any] = {}  # the dict of regex and info as defined by ZZ and parsed by TldInfo
         self.servers: list[str] = []  # extract whois servers from the whois output (may need --verbose on rfc1036/whois)