From 9335917b2dcdfd70da596b3b752320348b6bd563 Mon Sep 17 00:00:00 2001 From: Kent Hansen Date: Tue, 10 Mar 2026 14:19:05 -0400 Subject: [PATCH 1/5] log trip updates --- lib/concentrate/encoder/gtfs_realtime_helpers.ex | 5 +++++ lib/concentrate/encoder/trip_updates.ex | 3 +++ 2 files changed, 8 insertions(+) diff --git a/lib/concentrate/encoder/gtfs_realtime_helpers.ex b/lib/concentrate/encoder/gtfs_realtime_helpers.ex index ce544329..68e2495e 100644 --- a/lib/concentrate/encoder/gtfs_realtime_helpers.ex +++ b/lib/concentrate/encoder/gtfs_realtime_helpers.ex @@ -2,6 +2,7 @@ defmodule Concentrate.Encoder.GTFSRealtimeHelpers do @moduledoc """ Helper functions for encoding GTFS-Realtime files. """ + require Logger alias Concentrate.{StopTimeUpdate, TripDescriptor, VehiclePosition} import Calendar.ISO, only: [date_to_string: 4] @@ -213,6 +214,10 @@ defmodule Concentrate.Encoder.GTFSRealtimeHelpers do [] -> nil end + Logger.info( + "event=build_trip_update_entity trip_id=#{trip_id} route_id=#{trip_data.route_id} trip_data=#{inspect(trip)} stus=#{inspect(stus)} stop_time_update=#{inspect(stop_time_update)}" + ) + cond do match?([_ | _], stop_time_update) -> [ diff --git a/lib/concentrate/encoder/trip_updates.ex b/lib/concentrate/encoder/trip_updates.ex index f92d0e11..196b059c 100644 --- a/lib/concentrate/encoder/trip_updates.ex +++ b/lib/concentrate/encoder/trip_updates.ex @@ -3,6 +3,7 @@ defmodule Concentrate.Encoder.TripUpdates do Encodes a list of parsed data into a TripUpdates.pb file. """ @behaviour Concentrate.Encoder + require Logger alias Concentrate.StopTimeUpdate import Concentrate.Encoder.GTFSRealtimeHelpers @@ -15,6 +16,8 @@ defmodule Concentrate.Encoder.TripUpdates do entity: trip_update_feed_entity(groups, &build_stop_time_update/1) } + Logger.info("event=trip_update_encoded entity=#{inspect(message.entity)}") + :gtfs_realtime_proto.encode_msg(message, :FeedMessage) end From 1b706bca66c95db44cf4c2be07793e32c15ba816 Mon Sep 17 00:00:00 2001 From: Kent Hansen Date: Thu, 12 Mar 2026 10:15:13 -0400 Subject: [PATCH 2/5] block waiver log --- lib/concentrate/encoder/gtfs_realtime_helpers.ex | 4 ---- lib/concentrate/encoder/trip_updates.ex | 2 -- lib/concentrate/group_filter/cancelled_trip.ex | 12 ++++++++++++ 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/lib/concentrate/encoder/gtfs_realtime_helpers.ex b/lib/concentrate/encoder/gtfs_realtime_helpers.ex index 68e2495e..942a32cb 100644 --- a/lib/concentrate/encoder/gtfs_realtime_helpers.ex +++ b/lib/concentrate/encoder/gtfs_realtime_helpers.ex @@ -214,10 +214,6 @@ defmodule Concentrate.Encoder.GTFSRealtimeHelpers do [] -> nil end - Logger.info( - "event=build_trip_update_entity trip_id=#{trip_id} route_id=#{trip_data.route_id} trip_data=#{inspect(trip)} stus=#{inspect(stus)} stop_time_update=#{inspect(stop_time_update)}" - ) - cond do match?([_ | _], stop_time_update) -> [ diff --git a/lib/concentrate/encoder/trip_updates.ex b/lib/concentrate/encoder/trip_updates.ex index 196b059c..d9922339 100644 --- a/lib/concentrate/encoder/trip_updates.ex +++ b/lib/concentrate/encoder/trip_updates.ex @@ -16,8 +16,6 @@ defmodule Concentrate.Encoder.TripUpdates do entity: trip_update_feed_entity(groups, &build_stop_time_update/1) } - Logger.info("event=trip_update_encoded entity=#{inspect(message.entity)}") - :gtfs_realtime_proto.encode_msg(message, :FeedMessage) end diff --git a/lib/concentrate/group_filter/cancelled_trip.ex b/lib/concentrate/group_filter/cancelled_trip.ex index c46d654c..a9bea802 100644 --- a/lib/concentrate/group_filter/cancelled_trip.ex +++ b/lib/concentrate/group_filter/cancelled_trip.ex @@ -41,6 +41,18 @@ defmodule Concentrate.GroupFilter.CancelledTrip do now_fn, routes_module.route_type(route_id) ) -> + stus_log = + Enum.map(stop_time_updates, fn stu -> + %{ + stop_id: StopTimeUpdate.stop_id(stu), + schedule_relationship: StopTimeUpdate.schedule_relationship(stu) + } + end) + + Logger.info( + "event=bus_block_waiver_cancel trip_id=#{trip_id} route_id=#{route_id} stus=#{inspect(stus_log)}" + ) + cancel_group(group, gtfs_stop_times) is_nil(time) -> From 3f71f7928083057707daf0d819825e3a47074f8c Mon Sep 17 00:00:00 2001 From: Kent Hansen Date: Thu, 12 Mar 2026 14:26:22 -0400 Subject: [PATCH 3/5] log during merge filter --- lib/concentrate/merge_filter.ex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/concentrate/merge_filter.ex b/lib/concentrate/merge_filter.ex index 55464075..35c37c86 100644 --- a/lib/concentrate/merge_filter.ex +++ b/lib/concentrate/merge_filter.ex @@ -136,14 +136,14 @@ defmodule Concentrate.MergeFilter do _ = Logger.debug(fn -> - "#{__MODULE__} group time=#{time / 1_000}" + "#{__MODULE__} group time=#{time / 1_000} grouped=#{inspect(grouped)}" end) {time, group_filtered} = :timer.tc(&group_filter/2, [grouped, state.group_filters]) _ = Logger.debug(fn -> - "#{__MODULE__} group_filter time=#{time / 1_000}" + "#{__MODULE__} group_filter time=#{time / 1_000} group_filtered=#{inspect(group_filtered)}" end) if group_filtered != [] || is_nil(keys) do From 80c4b74b363d842f95417e52437a8642a4920ada Mon Sep 17 00:00:00 2001 From: Kent Hansen Date: Thu, 12 Mar 2026 15:32:03 -0400 Subject: [PATCH 4/5] update logging --- lib/concentrate/merge_filter.ex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/concentrate/merge_filter.ex b/lib/concentrate/merge_filter.ex index 35c37c86..c2fe187a 100644 --- a/lib/concentrate/merge_filter.ex +++ b/lib/concentrate/merge_filter.ex @@ -136,14 +136,14 @@ defmodule Concentrate.MergeFilter do _ = Logger.debug(fn -> - "#{__MODULE__} group time=#{time / 1_000} grouped=#{inspect(grouped)}" + "#{__MODULE__} group time=#{time / 1_000} grouped_length=#{length(grouped)}" end) {time, group_filtered} = :timer.tc(&group_filter/2, [grouped, state.group_filters]) _ = Logger.debug(fn -> - "#{__MODULE__} group_filter time=#{time / 1_000} group_filtered=#{inspect(group_filtered)}" + "#{__MODULE__} group_filter time=#{time / 1_000} group_filtered_length=#{length(group_filtered)}" end) if group_filtered != [] || is_nil(keys) do From 2b80ca604400349f2c70d6e5717a347c0b70110e Mon Sep 17 00:00:00 2001 From: Kent Hansen Date: Thu, 12 Mar 2026 15:35:33 -0400 Subject: [PATCH 5/5] update logging --- lib/concentrate/encoder/gtfs_realtime_helpers.ex | 1 - lib/concentrate/encoder/trip_updates.ex | 1 - lib/concentrate/group_filter/cancelled_trip.ex | 12 ------------ 3 files changed, 14 deletions(-) diff --git a/lib/concentrate/encoder/gtfs_realtime_helpers.ex b/lib/concentrate/encoder/gtfs_realtime_helpers.ex index 942a32cb..ce544329 100644 --- a/lib/concentrate/encoder/gtfs_realtime_helpers.ex +++ b/lib/concentrate/encoder/gtfs_realtime_helpers.ex @@ -2,7 +2,6 @@ defmodule Concentrate.Encoder.GTFSRealtimeHelpers do @moduledoc """ Helper functions for encoding GTFS-Realtime files. """ - require Logger alias Concentrate.{StopTimeUpdate, TripDescriptor, VehiclePosition} import Calendar.ISO, only: [date_to_string: 4] diff --git a/lib/concentrate/encoder/trip_updates.ex b/lib/concentrate/encoder/trip_updates.ex index d9922339..f92d0e11 100644 --- a/lib/concentrate/encoder/trip_updates.ex +++ b/lib/concentrate/encoder/trip_updates.ex @@ -3,7 +3,6 @@ defmodule Concentrate.Encoder.TripUpdates do Encodes a list of parsed data into a TripUpdates.pb file. """ @behaviour Concentrate.Encoder - require Logger alias Concentrate.StopTimeUpdate import Concentrate.Encoder.GTFSRealtimeHelpers diff --git a/lib/concentrate/group_filter/cancelled_trip.ex b/lib/concentrate/group_filter/cancelled_trip.ex index a9bea802..c46d654c 100644 --- a/lib/concentrate/group_filter/cancelled_trip.ex +++ b/lib/concentrate/group_filter/cancelled_trip.ex @@ -41,18 +41,6 @@ defmodule Concentrate.GroupFilter.CancelledTrip do now_fn, routes_module.route_type(route_id) ) -> - stus_log = - Enum.map(stop_time_updates, fn stu -> - %{ - stop_id: StopTimeUpdate.stop_id(stu), - schedule_relationship: StopTimeUpdate.schedule_relationship(stu) - } - end) - - Logger.info( - "event=bus_block_waiver_cancel trip_id=#{trip_id} route_id=#{route_id} stus=#{inspect(stus_log)}" - ) - cancel_group(group, gtfs_stop_times) is_nil(time) ->