Return a filehandle instead of PDF content [#3]#4
Open
robrwo wants to merge 2 commits into
Open
Conversation
This returns a filehandle instead of the actual content of the PDF. It uses IO::File::WithPath so that the Plack XSendfile middleware can work with HTTP servers that support X-Sendfile extensions to have the PDF served directly by the web server.
Owner
|
Thanks for the patch. |
Author
|
Any progress on this? |
Owner
|
I'm planning to integrate thin in the upcoming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This returns a filehandle instead of the actual content of the PDF.
It uses IO::File::WithPath so that the Plack XSendfile middleware
can work with HTTP servers that support X-Sendfile extensions to
have the PDF served directly by the web server.