Skip to content

Return a filehandle instead of PDF content [#3]#4

Open
robrwo wants to merge 2 commits into
mc7244:masterfrom
robrwo:master
Open

Return a filehandle instead of PDF content [#3]#4
robrwo wants to merge 2 commits into
mc7244:masterfrom
robrwo:master

Conversation

@robrwo
Copy link
Copy Markdown

@robrwo robrwo commented Dec 4, 2017

This returns a filehandle instead of the actual content of the PDF.
It uses IO::File::WithPath so that the Plack XSendfile middleware
can work with HTTP servers that support X-Sendfile extensions to
have the PDF served directly by the web server.

This returns a filehandle instead of the actual content of the PDF.
It uses IO::File::WithPath so that the Plack XSendfile middleware
can work with HTTP servers that support X-Sendfile extensions to
have the PDF served directly by the web server.
@mc7244
Copy link
Copy Markdown
Owner

mc7244 commented Dec 5, 2017

Thanks for the patch.
However, returning a file handle instead of the content would likely break compatibility with exsiting installation, so I'll likely modify it to accept a parameter, or write a second method.

@robrwo
Copy link
Copy Markdown
Author

robrwo commented Jan 3, 2018

Any progress on this?

@mc7244
Copy link
Copy Markdown
Owner

mc7244 commented Jan 7, 2018

I'm planning to integrate thin in the upcoming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants