Fixed plugin parameters not saved when device is disconnected#1998
Open
mryhel wants to merge 1 commit into
Open
Fixed plugin parameters not saved when device is disconnected#1998mryhel wants to merge 1 commit into
mryhel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes:
InputPatch::getPluginParameters()andOutputPatch::getPluginParameters()returned an empty map when the plugin device was disconnected (m_plugin == NULL), causing all custom plugin parameters to be silently dropped when saving a workspace while the device is not connected.m_parametersCachealready existed and was used inreconnect(), butgetPluginParameters()ignored it. This fix adds the missing fallback.Related Issues: N/A
Checklist
{on a new line for functions and class definitions.Testing
Test Cases:
Test Results:
Before the fix — workspace opened with MIDI parameters configured, saved with device disconnected, parameters lost.
Was:
Became:
After the fix — same scenario, parameters preserved:
Was:
Became: