Skip to content

Fixed plugin parameters not saved when device is disconnected #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mryhel wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −6
Open

Fixed plugin parameters not saved when device is disconnected #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions engine/src/inputpatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,12 @@ void InputPatch::setPluginParameter(QString prop, QVariant value)
QMap<QString, QVariant> InputPatch::getPluginParameters()
{
if (m_plugin != NULL)
return m_plugin->getParameters(m_universe, m_pluginLine, QLCIOPlugin::Input);

return QMap<QString, QVariant>();
{
const auto params = m_plugin->getParameters(m_universe, m_pluginLine, QLCIOPlugin::Input);
if (!params.isEmpty())
return params;
}
return m_parametersCache;
}

void InputPatch::slotValueChanged(quint32 universe, quint32 input, quint32 channel,
Expand Down
9 changes: 6 additions & 3 deletions engine/src/outputpatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,12 @@ void OutputPatch::setPluginParameter(QString prop, QVariant value)
QMap<QString, QVariant> OutputPatch::getPluginParameters()
{
if (m_plugin != NULL)
return m_plugin->getParameters(m_universe, m_pluginLine, QLCIOPlugin::Output);

return QMap<QString, QVariant>();
{
const auto params = m_plugin->getParameters(m_universe, m_pluginLine, QLCIOPlugin::Output);
if (!params.isEmpty())
return params;
}
return m_parametersCache;
}

/*****************************************************************************
Expand Down
Loading