Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: mccaffers

CMakeLists.txt

@@ -50,17 +50,17 @@ file(GLOB_RECURSE SOURCES "source/*.cpp")
 # Create a library of your project's code
 add_library(BacktestingEngineLib STATIC ${SOURCES})
 
-# Replace find_package(OpenMP REQUIRED) with this:
+# Configure OpenMP. On Apple, provide Homebrew libomp hints before discovery.
 if(APPLE)
     set(OpenMP_C_FLAGS "-Xclang -fopenmp")
     set(OpenMP_CXX_FLAGS "-Xclang -fopenmp")
     set(OpenMP_C_LIB_NAMES "omp")
     set(OpenMP_CXX_LIB_NAMES "omp")
     set(OpenMP_omp_LIBRARY /opt/homebrew/opt/libomp/lib/libomp.dylib)
-    find_package(OpenMP REQUIRED)
     target_include_directories(BacktestingEngineLib PRIVATE /opt/homebrew/opt/libomp/include)
 endif()
 
+find_package(OpenMP REQUIRED)
 target_link_libraries(BacktestingEngineLib PUBLIC pqxx OpenMP::OpenMP_CXX)
 
 # Main executable

include/databaseConnection.hpp

@@ -20,7 +20,6 @@ class DatabaseConnection {
                         const std::string& password = "");
 
   void printResults(const std::vector<PriceData>& results) const;
-  std::vector<PriceData> executeQuery(const std::string& query) const;
   std::vector<PriceData> streamQuery(const std::string& query) const;
 
   const std::string& getConnectionString() const {

scripts/run.sh

@@ -5,9 +5,8 @@ current_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 # Build the source code
 # source $current_dir/environment.sh - no longer necessary
-source $current_dir/clean.sh
-source $current_dir/build.sh
-if [ $? -ne 0 ]; then
+source "$current_dir/clean.sh"
+if ! bash "$current_dir/build.sh"; then
     echo "Error: Build failed. Aborting."
     exit 1
 fi

source/databaseConnection.cpp

@@ -9,12 +9,15 @@
 #include <pqxx/pqxx>
 #include <cstdio>
 #include <charconv>
-#include <execution>
-#include <algorithm>
+#include <stdexcept>
 
 static std::chrono::system_clock::time_point fastParseTimestamp(const char* ts) {
-    int year, month, day, hour, min, sec, usec = 0;
-    std::sscanf(ts, "%4d-%2d-%2d %2d:%2d:%2d.%d", &year, &month, &day, &hour, &min, &sec, &usec);
+    int year = 0, month = 0, day = 0, hour = 0, min = 0, sec = 0, usec = 0;
+    const int parsedFields =
+        std::sscanf(ts, "%4d-%2d-%2d %2d:%2d:%2d.%d", &year, &month, &day, &hour, &min, &sec, &usec);
+    if (parsedFields != 6 && parsedFields != 7) {
+        throw std::runtime_error("Invalid timestamp format");
+    }
 
     // Cache timegm per date — tick data is time-ordered so date changes rarely
     static char cachedDate[11] = {};
@@ -53,7 +56,7 @@ std::vector<PriceData> DatabaseConnection::streamQuery(const std::string& query)
 
     std::vector<PriceData> results(result.size());
 
-    for (int i = 0; i < (int)result.size(); ++i) {
+    for (std::size_t i = 0; i < result.size(); ++i) {
         const auto& row = result[i];
         double ask, bid;
         auto symbol = row[0].view();

source/main.cpp

@@ -32,6 +32,10 @@ using json = nlohmann::json;
 //   argv[2] — Base64-encoded JSON strategy configuration
 int main(int argc, const char * argv[]) {
 
+  if (argc < 3) {
+    std::cerr << "Usage: " << argv[0] << " <questdb-host> <base64-config>" << std::endl;
+    return 1;
+  }
   DatabaseConnection db(argv[1], 8812, "qdb", "admin", "quest");
 
   JsonParser::parseConfigurationFromBase64(argv[2]);

source/operations.cpp

@@ -11,11 +11,13 @@
 #include <memory>
 #include <string>
 #include <iomanip>
+#include <cstdio>
+#include <ctime>
 #include "tradeManager.hpp"
 
 void Operations::run(const std::vector<PriceData>& ticks) {
 
-    // Loop aroudn every tick
+    // Loop around every tick
     // Example output:
     // symbol=AUSIDXAUD, ask=8602.4000, bid=8599.4000 timestamp=2026-03-12 18:39:01.076
     // symbol=AUSIDXAUD, ask=8602.9000, bid=8599.9000 timestamp=2026-03-12 18:39:01.584

source/sqlManager.cpp

@@ -4,6 +4,7 @@
 // This code is licensed under MIT license (see LICENSE.txt for details)
 // ---------------------------------------
 #include "sqlManager.hpp"
+#include <iostream>
 #include <string>
 #include <vector>