removing tickIndex, we don't need this variable

Author: mccaffers

include/strategies/randomStrategy.hpp

@@ -57,8 +57,7 @@ class RandomStrategy : public IStrategy {
     // is passed by mutable reference so future strategies (trailing
     // stops, partial closes, scale-ins) can act on open positions
     // here without changing the interface.
-    void during(std::size_t tickValue,
-                const PriceData& price,
+    void during(const PriceData& price,
                 TradeManager& tradeManager) override;
 
 private:

include/strategies/strategy.hpp

@@ -56,7 +56,6 @@ class IStrategy {
     // analogue is just passing the manager as a parameter; C# has no
     // distinction between reference and pointer so the by-ref nature
     // is implicit there.
-    virtual void during(std::size_t tickValue,
-                        const PriceData& price,
+    virtual void during(const PriceData& price,
                         TradeManager& tradeManager) = 0;
 };

source/operations.cpp

@@ -64,7 +64,6 @@ void Operations::run(const std::vector<PriceData>& ticks,
 
     const auto& tradingVars = config.STRATEGY.TRADING_VARIABLES;
 
-    std::size_t tickIndex = 0;
     for (const auto& tick : ticks) {
 
         // Close any trade whose stop-loss or take-profit fired on this tick
@@ -90,9 +89,7 @@ void Operations::run(const std::vector<PriceData>& ticks,
         // (e.g. trailing stops, partial closes). The default
         // RandomStrategy implementation is a no-op now that exits are
         // handled by reviewStopAndLimit above.
-        strategy->during(tickIndex, tick, *tradeManager);
-
-        ++tickIndex;
+        strategy->during(tick, *tradeManager);
     }
 
     std::cout << "Final PnL: " << std::fixed << std::setprecision(2) << tradeManager->calculatePnl() << std::endl;

source/strategies/randomStrategy.cpp

@@ -23,8 +23,7 @@ std::optional<Direction> RandomStrategy::decide(const PriceData& /*tick*/) {
     return coin(rng) ? Direction::LONG : Direction::SHORT;
 }
 
-void RandomStrategy::during(std::size_t /*tickValue*/,
-                            const PriceData& /*price*/,
+void RandomStrategy::during(const PriceData& /*price*/,
                             TradeManager& /*tradeManager*/) {
     // Exits are handled centrally by Operations using each trade's
     // stop-loss / take-profit pip distances. Strategies that want