Refactoring build pipeline

Author: mccaffers

.github/workflows/build.sh

@@ -17,7 +17,11 @@ export PKG_CONFIG_PATH="$(brew --prefix libpq)/lib/pkgconfig:$PKG_CONFIG_PATH"
 export PostgreSQL_ROOT="$(brew --prefix libpq)"
 
 # 1. Generate build files (Passing your CXX flags directly to CMake instead of configure)
-cmake .. -DCMAKE_CXX_STANDARD=20 -DCMAKE_BUILD_TYPE=Release 
+cmake .. \
+  -DCMAKE_CXX_STANDARD=20 \
+  -DCMAKE_BUILD_TYPE=Release \
+  -DCMAKE_OSX_SYSROOT=$(xcrun --show-sdk-path) \
+  -DSKIP_BUILD_TEST=ON
 
 # 2. Compile libpqxx
-make
+make -j$(sysctl -n hw.logicalcpu) 

.github/workflows/sonarcloud.yml

@@ -35,7 +35,8 @@ jobs:
 
     # Step 4: Build project external libraries
     - name: Build C++ Libraries
-      run: bash ./.github/workflows/build.sh
+      run: bash ./scripts/build_dep.sh
+      # run: bash ./.github/workflows/build.sh
 
     # Step 5: Configure Xcode version
     - name: Select Xcode version
@@ -92,7 +93,7 @@ jobs:
           cmake --version
       - name: Build C++ Libraries
         run: >
-            bash ./.github/workflows/build.sh
+            sh ./scripts/build.sh
       - name: Install Python 3.12 for gcovr
         uses: actions/setup-python@v5
         with: 

.vscode/c_cpp_properties.json

@@ -0,0 +1,12 @@
+{
+    "configurations": [
+        {
+            "name": "Mac",
+            "compileCommands": "${workspaceFolder}/build/compile_commands.json",
+            "includePath": [
+                "${workspaceFolder}/external/libpqxx/include"
+            ]
+        }
+    ],
+    "version": 4
+}

scripts/build.sh

@@ -12,8 +12,17 @@ fi
 # Step 2: Navigate to the build directory
 cd "$BUILD_DIR" || exit
 
-# Step 3: Run CMake to configure the project
-cmake ..
+# Expose paths so CMake finds libpq
+export PATH="$(brew --prefix libpq)/bin:$PATH"
+export PKG_CONFIG_PATH="$(brew --prefix libpq)/lib/pkgconfig:$PKG_CONFIG_PATH"
+export PostgreSQL_ROOT="$(brew --prefix libpq)"
+
+# 1. Generate build files (Passing your CXX flags directly to CMake instead of configure)
+cmake .. \
+  -DCMAKE_CXX_STANDARD=20 \
+  -DCMAKE_BUILD_TYPE=Release \
+  -DCMAKE_OSX_SYSROOT=$(xcrun --show-sdk-path) \
+  -DSKIP_BUILD_TEST=ON
 
 # Step 4: Compile the project
 cmake --build .

scripts/build_dep.sh

@@ -3,9 +3,15 @@ cd ./external/libpqxx
 mkdir -p build
 cd ./build
 
+# Expose paths so CMake finds libpq
 export PATH="$(brew --prefix libpq)/bin:$PATH"
 export PKG_CONFIG_PATH="$(brew --prefix libpq)/lib/pkgconfig:$PKG_CONFIG_PATH"
 export PostgreSQL_ROOT="$(brew --prefix libpq)"
 
-cmake .. -DCMAKE_CXX_STANDARD=20 -DCMAKE_BUILD_TYPE=Release 
+# 1. Generate build files (Passing your CXX flags directly to CMake instead of configure)
+cmake .. \
+  -DCMAKE_CXX_STANDARD=20 \
+  -DCMAKE_BUILD_TYPE=Release \
+  -DCMAKE_OSX_SYSROOT=$(xcrun --show-sdk-path) \
+  -DSKIP_BUILD_TEST=ON
 make

source/databaseConnection.cpp

@@ -57,7 +57,7 @@ std::vector<PriceData> DatabaseConnection::streamQuery(const std::string& query)
     std::vector<PriceData> results(result.size());
 
     for (std::size_t i = 0; i < result.size(); ++i) {
-        const auto& row = result[i];
+        const auto& row = result[static_cast<pqxx::result::size_type>(i)];
         double ask, bid;
         auto symbol = row[0].view();
         auto sv1 = row[1].view();

source/main.cpp

@@ -32,18 +32,24 @@ using json = nlohmann::json;
 //   argv[2] — Base64-encoded JSON strategy configuration
 int main(int argc, const char * argv[]) {
 
+  // Validate required command-line arguments before proceeding
   if (argc < 3) {
     std::cerr << "Usage: " << argv[0] << " <questdb-host> <base64-config>" << std::endl;
     return 1;
   }
+
+  // Connect to QuestDB on the default port (8812) using default credentials
   DatabaseConnection db(argv[1], 8812, "qdb", "admin", "quest");
 
+  // Decode and apply the strategy configuration from Base64-encoded JSON
   JsonParser::parseConfigurationFromBase64(argv[2]);
 
+  // Define the instruments to backtest and stream their historical tick data
   std::vector<std::string> symbols = {"AUSIDXAUD", "EURUSD"};
   std::vector<PriceData> ticks = SqlManager::streamPriceData(db, symbols, 1);
   printf("Total ticks streamed: %zu\n", ticks.size());
 
+  // Execute the backtest by replaying all ticks through the strategy logic
   Operations::run(ticks);
 
   return 0;