Conversation
…t the canonical symbol_scale table before query interpolation; unknown symbols are rejected with a clear error. - JSON parse errors no longer swallowed: parse failures propagate with byte-offset detail instead of continuing into a misleading downstream exception; leftover debug prints removed. - Thread-safety: timestamp-parse date cache moved from function-local statics to caller-owned state (safe if tick loading moves onto the thread pool); unchecked from_chars price parses now throw instead of producing garbage values (also covers NULL DB columns). - Dead code removed: scaffolding files (serviceA, configManager, empty trade.cpp), unused base64/timestamp utilities (one with a ms/µs conversion bug), printResults; Xcode project references scrubbed. - Build fixes: main.cpp no longer compiled into both the static lib and the executable; macOS-only xcrun guarded by if(APPLE); libomp located via brew --prefix (fixes Intel Macs); duplicate find_package(OpenMP) removed; global include_directories converted to target-scoped. - Minor: redundant PnL recomputation in Reporting::collect removed; unnecessary heap allocation of TradeManager replaced with a stack local.
mccaffers
changed the title
|
github-project-automation
Bot
moved this from In review
to Done
in @mccaffers Backtesting Project Tracking
mccaffers
deleted the
45-add-account-balance-mark-to-market-loss-limits-and-fail-fast-run-cutoff-codebase-hardening-from-code-review
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.