Add account balance, mark-to-market loss limits and fail-fast run cutoff; codebase hardening from code review #46

Merged

mccaffers merged 1 commit into

mainfrom

45-add-account-balance-mark-to-market-loss-limits-and-fail-fast-run-cutoff-codebase-hardening-from-code-review

Jun 9, 2026

SonarQubeCloud / SonarCloud Code Analysis failed Jun 9, 2026 in 1m 52s

Quality Gate failed

Failed conditions
48.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 84 in source/databaseConnection.cpp

sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "bidResult" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ6uLbvDbL0vMjHUErDx&open=AZ6uLbvDbL0vMjHUErDx&pullRequest=46

Check warning on line 42 in source/databaseConnection.cpp

sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "date" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ6uLbvDbL0vMjHUErDw&open=AZ6uLbvDbL0vMjHUErDw&pullRequest=46

Check warning on line 86 in source/databaseConnection.cpp

sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ6uLbvDbL0vMjHUErDy&open=AZ6uLbvDbL0vMjHUErDy&pullRequest=46

View more details on SonarQubeCloud