Skip to content

Commit 859bcfc

Browse files
authored
Merge pull request #471 from steps-re/fix/generated-vector-setter
fix: 2D-vector setter writes nothing (`-` instead of `=`)
2 parents 67dafd0 + 113f022 commit 859bcfc

7 files changed

Lines changed: 13 additions & 11 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/2.0.0/),
2626

2727
### Fixed
2828

29+
- Fix 2D-vector setter writes nothing (- instead of =) from [@steps-re]
30+
2931
### Security
3032

3133
## [0.14.1] - 2026-07-04

mcdc/code_factory/numba_objects_generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1141,7 +1141,7 @@ def _accessor_2d_vector(object_name, attribute_name, stride, setter=False):
11411141
text += f" start = offset + index_1 * stride\n"
11421142
text += f" end = start + stride\n"
11431143
if setter:
1144-
text += f" data[start:end] - value\n\n\n"
1144+
text += f" data[start:end] = value\n\n\n"
11451145
else:
11461146
text += f" return data[start:end]\n\n\n"
11471147
return text

mcdc/mcdc_set/multigroup_material.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ def mgxs_nu_d_vector(index_1, multigroup_material, data, value):
241241
stride = multigroup_material["J"]
242242
start = offset + index_1 * stride
243243
end = start + stride
244-
data[start:end] - value
244+
data[start:end] = value
245245

246246

247247
@njit
@@ -322,7 +322,7 @@ def mgxs_chi_s_vector(index_1, multigroup_material, data, value):
322322
stride = multigroup_material["G"]
323323
start = offset + index_1 * stride
324324
end = start + stride
325-
data[start:end] - value
325+
data[start:end] = value
326326

327327

328328
@njit
@@ -345,7 +345,7 @@ def mgxs_chi_p_vector(index_1, multigroup_material, data, value):
345345
stride = multigroup_material["G"]
346346
start = offset + index_1 * stride
347347
end = start + stride
348-
data[start:end] - value
348+
data[start:end] = value
349349

350350

351351
@njit
@@ -368,7 +368,7 @@ def mgxs_chi_d_vector(index_1, multigroup_material, data, value):
368368
stride = multigroup_material["G"]
369369
start = offset + index_1 * stride
370370
end = start + stride
371-
data[start:end] - value
371+
data[start:end] = value
372372

373373

374374
@njit

mcdc/mcdc_set/neutron_inelastic_scattering_reaction.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def spectrum_probability_vector(index_1, neutron_inelastic_scattering_reaction,
3838
stride = neutron_inelastic_scattering_reaction["N_spectrum"]
3939
start = offset + index_1 * stride
4040
end = start + stride
41-
data[start:end] - value
41+
data[start:end] = value
4242

4343

4444
@njit

mcdc/mcdc_set/source.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def move_velocities_vector(index_1, source, data, value):
99
stride = 3
1010
start = offset + index_1 * stride
1111
end = start + stride
12-
data[start:end] - value
12+
data[start:end] = value
1313

1414

1515
@njit
@@ -90,7 +90,7 @@ def move_translations_vector(index_1, source, data, value):
9090
stride = 3
9191
start = offset + index_1 * stride
9292
end = start + stride
93-
data[start:end] - value
93+
data[start:end] = value
9494

9595

9696
@njit

mcdc/mcdc_set/surface.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def move_velocities_vector(index_1, surface, data, value):
99
stride = 3
1010
start = offset + index_1 * stride
1111
end = start + stride
12-
data[start:end] - value
12+
data[start:end] = value
1313

1414

1515
@njit
@@ -90,7 +90,7 @@ def move_translations_vector(index_1, surface, data, value):
9090
stride = 3
9191
start = offset + index_1 * stride
9292
end = start + stride
93-
data[start:end] - value
93+
data[start:end] = value
9494

9595

9696
@njit

mcdc/mcdc_set/table_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def aux_vector(index_1, table_data, data, value):
125125
stride = table_data["N"]
126126
start = offset + index_1 * stride
127127
end = start + stride
128-
data[start:end] - value
128+
data[start:end] = value
129129

130130

131131
@njit

0 commit comments

Comments
 (0)