Proof of concept for combined state#419
Draft
braxtoncuneo wants to merge 1 commit into
Draft
Conversation
|
Cool, I've linked to this proof of concept PR from upstream as a potential demonstration of real-world utility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR provides a refactor that re-combines the tally state of MC/DC with the primary global state. This is done to test if the the numpy PR mentioned in #408 by @tylerjereddy solves the issues of overly-large arrays inside of dtypes in MC/DC.
This PR is for the
cementbranch, which represents a legacy version of MC/DC. It is based upon this older branch since it is already established to work on gpu/cpu and so would be easier to review for issues. If this version is successful, a similar set of changes would be on the docket for the main branch.Types of changes
Associated Issues and PRs