Improvements to the Upgrader. It should now work more reliably and a logic flaw was fixed

piac · piac · commit fcbbbd997e68 · 2013-10-22T19:00:57.000+02:00
diff --git a/Component/PyUpgrader.cs b/Component/PyUpgrader.cs
@@ -17,7 +17,7 @@ public IGH_DocumentObject Upgrade(IGH_DocumentObject target, GH_Document documen
       component_new.HiddenCodeInput = component_OBSOLETE.HiddenCodeInput;
       component_new.HiddenOutOutput = component_OBSOLETE.HiddenOutOutput;
 
-      if (!component_new.HiddenCodeInput)
+      if (component_new.HiddenCodeInput)
         component_new.Code = component_OBSOLETE.Code;
 
       if (GH_UpgradeUtil.SwapComponents(component_OBSOLETE, component_new))
diff --git a/Component/PythonComponent.cs b/Component/PythonComponent.cs
@@ -181,7 +181,10 @@ public bool IsOutputVariable
 
     public bool IsVariableParam(GH_VarParamEventArgs e)
     {
-      return e.Index > (!HiddenCodeInput ? -1 : 0);
+      if(e.Side == GH_VarParamSide.Input)
+        return e.Index > (HiddenCodeInput ? -1 : 0);
+      else
+        return e.Index > (HiddenOutOutput ? -1 : 0);
     }
 
     public void ManagerConstructed(GH_VarParamSide side, Grasshopper.GUI.GH_VariableParameterManager manager)

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,10 @@ public bool IsOutputVariable`
`181`	`181`
`182`	`182`	`public bool IsVariableParam(GH_VarParamEventArgs e)`
`183`	`183`	`{`
`184`		`- return e.Index > (!HiddenCodeInput ? -1 : 0);`
	`184`	`+ if(e.Side == GH_VarParamSide.Input)`
	`185`	`+ return e.Index > (HiddenCodeInput ? -1 : 0);`
	`186`	`+ else`
	`187`	`+ return e.Index > (HiddenOutOutput ? -1 : 0);`
`185`	`188`	`}`
`186`	`189`
`187`	`190`	`public void ManagerConstructed(GH_VarParamSide side, Grasshopper.GUI.GH_VariableParameterManager manager)`