Skip to content

Ensure projects with warnings fail the ci/cd check #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clicky wants to merge 2 commits into
base: 9
Choose a base branch
from
Open

Ensure projects with warnings fail the ci/cd check #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b42fb21
Ensure projects with warnings fail the ci/cd check
clicky Jun 2, 2026
1499cb3
Added NoWarn for 1701;1702;NU1701
clicky Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-samples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
}

Write-Host "::group::Building $rel"
dotnet build $proj.FullName -c Release --nologo
dotnet build $proj.FullName -c Release --nologo -warnaserror
$code = $LASTEXITCODE
Write-Host "::endgroup::"
if ($code -eq 0) {
Expand Down
4 changes: 4 additions & 0 deletions rhino.inside/dotnet-netcore/BatchOperation/BatchOperation.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
<SupportedOSPlatformVersion>7.0</SupportedOSPlatformVersion>
</PropertyGroup>

<PropertyGroup>
<NoWarn>1701;1702;NU1701</NoWarn>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Rhino.Inside" Version="8.0.6-beta" />
</ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions rhino.inside/dotnet-netcore/HelloWorld/HelloWorld.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
<SupportedOSPlatformVersion>8.0</SupportedOSPlatformVersion>
</PropertyGroup>

<PropertyGroup>
<NoWarn>1701;1702;NU1701</NoWarn>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Rhino.Inside" Version="8.0.6-beta" />
</ItemGroup>
Expand Down
6 changes: 5 additions & 1 deletion rhino.inside/dotnet-netcore/SampleConvert/Convert.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0-Windows</TargetFramework>
<TargetFramework>net8.0-windows</TargetFramework>
</PropertyGroup>

<PropertyGroup>
<NoWarn>1701;1702;NU1701</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading