Skip to content

Commit 7a11a9b

Browse files
authored
tls: move _tls_* to end-of-life
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> PR-URL: nodejs#60658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
1 parent 56387dd commit 7a11a9b

11 files changed

Lines changed: 6 additions & 55 deletions

doc/api/deprecations.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4231,6 +4231,9 @@ npx codemod@latest @nodejs/repl-builtin-modules
42314231

42324232
<!-- YAML
42334233
changes:
4234+
- version: REPLACEME
4235+
pr-url: https://github.com/nodejs/node/pull/60658
4236+
description: End-of-Life.
42344237
- version:
42354238
- v24.2.0
42364239
- v22.17.0
@@ -4239,7 +4242,7 @@ changes:
42394242
description: Runtime deprecation.
42404243
-->
42414244

4242-
Type: Runtime
4245+
Type: End-of-Life
42434246

42444247
The `node:_tls_common` and `node:_tls_wrap` modules are deprecated as they should be considered
42454248
an internal nodejs implementation rather than a public facing API, use `node:tls` instead.

lib/_tls_common.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

lib/_tls_wrap.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

lib/eslint.config_partial.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,6 @@ export default [
544544
{
545545
files: [
546546
'lib/_http_*.js',
547-
'lib/_tls_*.js',
548547
'lib/http.js',
549548
'lib/http2.js',
550549
'lib/internal/http.js',

lib/internal/main/mksnapshot.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ const supportedModules = new SafeSet(new SafeArrayIterator([
4242
// '_http_incoming',
4343
// '_http_outgoing',
4444
// '_http_server',
45-
// '_tls_common',
46-
// '_tls_wrap',
4745
'assert',
4846
'assert/strict',
4947
// 'async_hooks',

src/node_builtins.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ BuiltinLoader::BuiltinCategories BuiltinLoader::GetBuiltinCategories() const {
130130
#endif // !NODE_USE_V8_PLATFORM || !defined(NODE_HAVE_I18N_SUPPORT)
131131

132132
#if !HAVE_OPENSSL
133-
"crypto", "crypto/promises", "https", "http2", "tls", "_tls_common",
134-
"_tls_wrap", "internal/tls/parse-cert-string", "internal/tls/common",
133+
"crypto", "crypto/promises", "https", "http2", "tls",
134+
"internal/tls/parse-cert-string", "internal/tls/common",
135135
"internal/tls/wrap", "internal/tls/secure-context",
136136
"internal/http2/core", "internal/http2/compat",
137137
"internal/streams/lazy_transform",

test/parallel/test-internal-module-require.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ const expectedPublicModules = new Set([
2424
'_http_incoming',
2525
'_http_outgoing',
2626
'_http_server',
27-
'_tls_common',
28-
'_tls_wrap',
2927
'assert',
3028
'async_hooks',
3129
'buffer',

test/parallel/test-process-get-builtin.mjs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ if (!isMainThread) {
2525
if (!hasCrypto) {
2626
publicBuiltins.delete('crypto');
2727
publicBuiltins.delete('tls');
28-
publicBuiltins.delete('_tls_common');
29-
publicBuiltins.delete('_tls_wrap');
3028
publicBuiltins.delete('http2');
3129
publicBuiltins.delete('https');
3230
publicBuiltins.delete('inspector');

test/parallel/test-warn-tls-common-deprecation.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

test/parallel/test-warn-tls-wrap-deprecation.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)